Merge pull request #840 from newrelic-forks/fix_service_memory_leak

Service Api collection close servicehandler to avoid memory leak
This commit is contained in:
Ben Reedy
2021-09-25 18:22:21 +10:00
committed by GitHub

View File

@@ -246,18 +246,17 @@ func (c *serviceCollector) collectAPI(ch chan<- prometheus.Metric) error {
if err != nil { if err != nil {
continue continue
} }
defer serviceHandle.Close()
// Get Service Configuration // Get Service Configuration
serviceConfig, err := serviceHandle.Config() serviceConfig, err := serviceHandle.Config()
if err != nil { if err != nil {
_ = serviceHandle.Close()
continue continue
} }
// Get Service Current Status // Get Service Current Status
serviceStatus, err := serviceHandle.Query() serviceStatus, err := serviceHandle.Query()
if err != nil { if err != nil {
_ = serviceHandle.Close()
continue continue
} }