From f4f5aaf14688207908fc5cc2f85c9e3cae0f0159 Mon Sep 17 00:00:00 2001 From: Alvaro Cabanas Date: Thu, 23 Sep 2021 17:37:09 +0200 Subject: [PATCH] Service Api collection close servicehandler to avoid memory leak Signed-off-by: Alvaro Cabanas --- collector/service.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/collector/service.go b/collector/service.go index 396de181..3ef2f72d 100644 --- a/collector/service.go +++ b/collector/service.go @@ -246,18 +246,17 @@ func (c *serviceCollector) collectAPI(ch chan<- prometheus.Metric) error { if err != nil { continue } + defer serviceHandle.Close() // Get Service Configuration serviceConfig, err := serviceHandle.Config() if err != nil { - _ = serviceHandle.Close() continue } // Get Service Current Status serviceStatus, err := serviceHandle.Query() if err != nil { - _ = serviceHandle.Close() continue }