Merge pull request #840 from newrelic-forks/fix_service_memory_leak

Service Api collection close servicehandler to avoid memory leak

collector/service.go

@@ -246,18 +246,17 @@ func (c *serviceCollector) collectAPI(ch chan<- prometheus.Metric) error {
 		if err != nil {
 			continue
 		}
+		defer serviceHandle.Close()
 
 		// Get Service Configuration
 		serviceConfig, err := serviceHandle.Config()
 		if err != nil {
-			_ = serviceHandle.Close()
 			continue
 		}
 
 		// Get Service Current Status
 		serviceStatus, err := serviceHandle.Query()
 		if err != nil {
-			_ = serviceHandle.Close()
 			continue
 		}