Merge pull request #234 from szook/fix-mssql-metric-name-typo

fix mssql metric name type
2026-02-08 14:06:38 +00:00 · 2018-08-03 16:27:40 +02:00 · 2018-08-03 09:52:15 -04:00 · 2018-08-02 08:42:02 +02:00 · 2018-07-23 16:20:07 +02:00 · 2018-07-23 07:53:50 -04:00
3 changed files with 2876 additions and 3 deletions
--- a/README.md
+++ b/README.md
@@ -9,15 +9,16 @@ Prometheus exporter for Windows machines, using the WMI (Windows Management Inst

 Name     | Description | Enabled by default
 ---------|-------------|--------------------
-ad | [Win32_PerfRawData_DirectoryServices_DirectoryServices](https://msdn.microsoft.com/en-us/library/ms803980.aspx) Active Directory | 
+ad | [Win32_PerfRawData_DirectoryServices_DirectoryServices](https://msdn.microsoft.com/en-us/library/ms803980.aspx) Active Directory |
 cpu | [Win32_PerfRawData_PerfOS_Processor](https://msdn.microsoft.com/en-us/library/aa394317(v=vs.90).aspx) metrics (cpu usage) | &#10003;
 cs | [Win32_ComputerSystem](https://msdn.microsoft.com/en-us/library/aa394102) metrics (system properties, num cpus/total memory) | &#10003;
 dns | [Win32_PerfRawData_DNS_DNS](https://technet.microsoft.com/en-us/library/cc977686.aspx) metrics (DNS Server) |
-hyperv | Performance counters for Hyper-V hosts | 
+hyperv | Performance counters for Hyper-V hosts |
 iis | [Win32_PerfRawData_W3SVC_WebService](https://msdn.microsoft.com/en-us/library/aa394345) IIS metrics |
 logical_disk | [Win32_PerfRawData_PerfDisk_LogicalDisk](https://msdn.microsoft.com/en-us/windows/hardware/aa394307(v=vs.71)) metrics (disk I/O) | &#10003;
 net | [Win32_PerfRawData_Tcpip_NetworkInterface](https://technet.microsoft.com/en-us/security/aa394340(v=vs.80)) metrics (network interface I/O) | &#10003;
-msmq | [Win32_PerfRawData_MSMQ_MSMQQueue](http://wutils.com/wmi/root/cimv2/win32_perfrawdata_msmq_msmqqueue/) metrics (MSMQ/journal count) | 
+msmq | [Win32_PerfRawData_MSMQ_MSMQQueue](http://wutils.com/wmi/root/cimv2/win32_perfrawdata_msmq_msmqqueue/) metrics (MSMQ/journal count) |
+mssql | various [SQL Server Performance Objects](https://docs.microsoft.com/en-us/sql/relational-databases/performance-monitor/use-sql-server-objects#SQLServerPOs) metrics  |
 os | [Win32_OperatingSystem](https://msdn.microsoft.com/en-us/library/aa394239) metrics (memory, processes, users) | &#10003;
 process | [Win32_PerfRawData_PerfProc_Process](https://msdn.microsoft.com/en-us/library/aa394323(v=vs.85).aspx) metrics (per-process stats) |
 service | [Win32_Service](https://msdn.microsoft.com/en-us/library/aa394418(v=vs.85).aspx) metrics (service states) | &#10003;
--- a/collector/mssql.go
+++ b/collector/mssql.go
--- a/collector/process.go
+++ b/collector/process.go
@@ -177,6 +177,11 @@ type Win32_PerfRawData_PerfProc_Process struct {
 	WorkingSetPrivate       uint64
 }

+type WorkerProcess struct {
+	AppPoolName string
+	ProcessId   uint32
+}
+
 func (c *ProcessCollector) collect(ch chan<- prometheus.Metric) (*prometheus.Desc, error) {
 	var dst []Win32_PerfRawData_PerfProc_Process
 	q := queryAllWhere(&dst, c.queryWhereClause)
@@ -184,6 +189,10 @@ func (c *ProcessCollector) collect(ch chan<- prometheus.Metric) (*prometheus.Des
 		return nil, err
 	}

+	var dst_wp []WorkerProcess
+	q_wp := queryAll(&dst_wp)
+	wmi.QueryNamespace(q_wp, &dst_wp, "root\\WebAdministration")
+
 	for _, process := range dst {

 		if process.Name == "_Total" {
@@ -194,6 +203,13 @@ func (c *ProcessCollector) collect(ch chan<- prometheus.Metric) (*prometheus.Des
 		pid := strconv.FormatUint(uint64(process.IDProcess), 10)
 		cpid := strconv.FormatUint(uint64(process.CreatingProcessID), 10)

+		for _, wp := range dst_wp {
+			if wp.ProcessId == process.IDProcess {
+				processName = strings.Join([]string{processName, wp.AppPoolName}, "_")
+				break
+			}
+		}
+
 		ch <- prometheus.MustNewConstMetric(
 			c.StartTime,
 			prometheus.GaugeValue,
Author	SHA1	Message	Date
Calle Pettersson	96dd456bb1	Merge pull request #234 from szook/fix-mssql-metric-name-typo fix mssql metric name type	2018-08-03 16:27:40 +02:00
Steve Zook	af1b8bf4d0	fix mssql metric name type found that I had one metric with an extra `s` in `_genstatss_`, making it inconsistent with it's siblings.	2018-08-03 09:52:15 -04:00
szook	fe4c61a70e	Add mssql collector (#230 ) add mssql collector	2018-08-02 08:42:02 +02:00
Calle Pettersson	143705bbf6	Merge pull request #227 from szook/add-worker-process-name-to-w3wp-processes append IIS worker process name to corresponding w3wp processes	2018-07-23 16:20:07 +02:00
Steve Zook	e8ffb736d0	add worker process name to w3wp processes modify the `process` collector so that the IIS worker process name is appended to the corresponding `w3wp` process. before: ``` wmi_process_private_bytes{creating_process_id="2068",process="w3wp",process_id="12308"} 7.18204928e+08 ``` after: ``` wmi_process_private_bytes{creating_process_id="2068",process="w3wp_our.website.com",process_id="12308"} 7.18204928e+08 ``` reason: We have some IIS servers hosting many .NET applications. When there is resource contention on one of those servers, it's nice to know which IIS application pool is the culprit. Having only the process_id to differentiate between w3wp processes requires additional work to figure out which is which. Also it does not allow for historial trending as the process_id can change across restarts.	2018-07-23 07:53:50 -04:00