Ben Reedy
cc45eeb90b
Merge pull request #809 from breed808/process_working_set_private
...
Add missing Process Collector metrics
2021-06-25 08:36:43 +10:00
Ben Reedy
4b2cd0a024
Merge pull request #759 from breed808/textfile
...
Fix textfile crashes with duplicate metrics
2021-06-25 08:36:21 +10:00
Ben Reedy
ad447a6b08
Add unit suffix to process working_set metric
...
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-06-19 09:02:30 +10:00
Ben Reedy
e4d7604193
Move process metric documentation to markdown file
...
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-06-19 09:02:28 +10:00
Ben Reedy
757f88be04
Add missing process counters
...
Working Set Private and Working Set Peak were being collected, but not
exposed by the exporter.
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-06-19 09:02:26 +10:00
Calle Pettersson
cff484b5e1
Merge pull request #804 from max-len/bandwidth-bytes
...
Export CurrentBandwidth as bytes
2021-06-16 20:16:45 +02:00
Calle Pettersson
2dc568b5cd
Merge pull request #805 from max-len/typo
...
Fix typo: process_memory_limit_bytes
2021-06-16 20:14:55 +02:00
Calle Pettersson
448f505729
Merge pull request #807 from max-len/doc-cpu
...
Fix doc: collector.cpu.md
2021-06-16 20:12:59 +02:00
Max Lendrich
6d1ba11a8e
Fix doc: collector.cpu.md
...
Signed-off-by: Max Lendrich <maximilian.lendrich@sap.com >
2021-06-16 15:18:29 +02:00
Max Lendrich
0f5a232142
Fix typo
...
Signed-off-by: Max Lendrich <maximilian.lendrich@sap.com >
2021-06-15 12:38:23 +02:00
Max Lendrich
bbab591570
Export CurrentBandwidth as bytes
...
From https://prometheus.io/docs/practices/naming/ :
To avoid confusion combining different metrics, always use bytes, even
where bits appear more common.
Fixes #800
Signed-off-by: Max Lendrich <maximilian.lendrich@sap.com >
2021-06-14 17:33:27 +02:00
Ben Reedy
2bc3c1859a
Merge pull request #802 from breed808/log_dependency
...
Replace deprecated log lib in remaining collectors
2021-06-12 19:52:29 +10:00
Ben Reedy
7c61a4dc25
Run "go mod tidy" on project
...
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-06-12 11:57:46 +10:00
Ben Reedy
5a57da53be
Replace deprecated log lib in remaining collectors
...
Some collectors were missed when migrating to the local
github.com/prometheus-community/windows_exporter/log library.
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-06-12 11:57:40 +10:00
Calle Pettersson
72c46664db
Merge pull request #789 from Wittionary/issue-776
...
Fixes #776
2021-05-25 07:35:49 +02:00
Witt Allen
8689c41c68
Added a 'data source' field to specify hcsshim of Host Compute Services in Hyper-V is used
...
Signed-off-by: Witt Allen <qwert59@gmail.com >
2021-05-24 00:57:20 -05:00
Calle Pettersson
74eac8f29b
Merge pull request #788 from benridley/bugfix_sysinfo_layout
...
Correct layout of SystemInfo structs
2021-05-21 09:41:34 +02:00
Ben Ridley
bb48f1caac
Correct layout of SystemInfo structs to prevent incorrect fields being read
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-05-20 16:30:52 -07:00
Ben Reedy
068d03bd01
Merge pull request #783 from breed808/msmq_remove_hardcoded_queue
...
Remove hard-coded "Computer Queues" filter
2021-05-17 16:58:50 +10:00
Ben Reedy
5072879dca
Check duplicates across entire textfile set
...
Check all textfile metrics will be checked for duplicates. If duplicates
are detected, drop all metrics and log error.
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-05-17 16:54:28 +10:00
Ben Reedy
0fb7eec670
Remove hard-coded "Computer Queues" filter
...
msmq collector would only collect from a hard-coded "Computer Queues"
queue.
Removal of filter allows other queues to be queried with
the collector.msmq.msmq-where flag.
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-05-16 14:53:54 +10:00
Ben Reedy
4293497b29
Fix textfile crashes with duplicate metrics
...
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-05-12 20:57:17 +10:00
Ben Reedy
95f10f19cb
Merge pull request #778 from Wittionary/fix-issue-777
...
Fixes #777
2021-05-03 14:23:03 +10:00
Witt
288f2a60e7
Changed 'Yes' to 'No' to reflect current state of collectors enabled by default
...
Signed-off-by: Witt Allen <qwert59@gmail.com >
2021-05-02 19:40:33 -05:00
Ben Reedy
2e32b0e2b1
Merge pull request #767 from louij2/patch-1
...
Update collector.service.md
2021-05-01 13:14:26 +10:00
Calle Pettersson
09759a4e8c
Merge pull request #698 from ramonsmits/patch-1
...
Example - Using [defaults] with `--collectors.enabled` argument
2021-04-25 19:53:42 +02:00
louij2
dfd42a6c0c
Update collector.service.md
...
Added more details for monitoring multiple services.
Signed-off-by: Luca Chana <clubdog123@gmail.com >
2021-04-24 21:05:36 +01:00
Ramon Smits
576c3bf918
Example - Using [defaults] with --collectors.enabled argument
...
Signed-off-by: Ramon Smits <ramon.smits@gmail.com >
2021-04-23 18:52:52 +02:00
Ben Reedy
19fee044bf
Merge pull request #765 from breed808/checksums
...
CI: Output artifacts in single, flat directory.
2021-04-20 19:00:35 +10:00
Ben Reedy
45a74fdb7f
CI: Output artifacts in single, flat directory.
...
Nested directories caused issues with promu checksum output, causing
user checks of the sha265sums.txt file to fail as the filenames did not
match.
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-04-19 19:38:17 +10:00
Ben Reedy
db00553ca6
Merge pull request #744 from breed808/tests
...
Add benchmark for each collector
2021-04-01 22:35:08 +10:00
Ben Reedy
a2c4bf6a2d
Add benchmark for each collector
...
Benchmarks will allow for easier identification of slow collectors.
Additionally, they increase test coverage of the collectors, with some
collectors now reaching 80-95% coverage with this change.
Collector benchmarks have been structed so that common functionality is
present in `collector/collector_test.go` as is done with non-test
functionality in `collector/collector.go`.
Test logic that is specific to individual collectors is present in the
collector test file (E.G. `collector/process_test.go` for the Process
collector).
Signed-off-by: Ben Reedy <breed808@breed808.com >
2021-04-01 22:28:54 +10:00
Calle Pettersson
7adcac8f39
Merge pull request #702 from benridley/dev_cs_collector
...
Replace WMI in cs and os collectors
2021-03-30 21:26:23 +02:00
Ben Ridley
863b7d8ab4
Merge branch 'dev_cs_collector' of https://github.com/benridley/windows_exporter into dev_cs_collector
2021-03-29 10:14:26 -07:00
Ben Ridley
33c6b2c6a5
Address GitHub feedback
...
- Defer registry close calls
- Ensure size parameter in GetComputerName is properly specified
- Clean up some comments to ensure correctness
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-29 10:13:36 -07:00
Calle Pettersson
6dee2422e1
Merge pull request #753 from prometheus-community/fix-ci
...
Update CI to install tools with go install rather than go get
2021-03-28 10:41:25 +02:00
Calle Pettersson
5d224b43ca
Update CI to install tools with go install rather than go get
...
Signed-off-by: Calle Pettersson <calle@cape.nu >
2021-03-27 15:30:50 +01:00
Calle Pettersson
3f2a143104
Merge pull request #748 from majerus1223/remote_interactive
...
Fix typo on remote_interactive
2021-03-19 11:34:25 +01:00
Ben Ridley
ee3848141c
Simplify struct usage and comments
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
Ben Ridley
df2a7a9ec0
Remove temporary uintptr values, as the garbage collector can move addresses from under them.
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
Ben Ridley
05f0f6f688
Add idiomatic wrappers to be exposed publically, and hide low-level
...
WinAPI operations
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
Ben Ridley
d947d0f6db
Refactor remaining sysinfoapi calls into header package
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
Ben Ridley
d063bc0842
Add correct scrape context to OS benchmark
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
retryW
dd473c4807
Fixed paging free bytes
...
moved
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
retryW
7bd58abd27
Converted PagingFreeBytes to use perflib
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
retryW
6f941044c7
Change Sprintf interpolation to use explicit types
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
retryW
3da11645cf
added os_test.go and removed wmi for testing
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
retryW
048bff919e
Converted most metrics to non-wmi
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
retryW
f76334213d
Convert os time and timezone from WMI to native go
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00
Ben Ridley
71054ac429
Replace the CS collector with native WinAPI calls to sysinfoapi
...
Signed-off-by: Ben Ridley <benridley29@gmail.com >
2021-03-18 16:18:47 -07:00