refactor: pass context to shutdownServer

This commit is contained in:
Elias Schneider
2026-04-19 20:14:20 +02:00
parent 444f7ff2b0
commit ff26c4273a

View File

@@ -264,7 +264,7 @@ func runServer(ctx context.Context, config *serverConfig) error {
notifySystemdReady()
<-ctx.Done()
return shutdownServer(config.server)
return shutdownServer(ctx, config.server)
}
func startCertWatcher(ctx context.Context, certProvider *tlsCertProvider) (*fsnotify.Watcher, error) {
@@ -321,10 +321,9 @@ func notifySystemdReady() {
}
}
func shutdownServer(srv *http.Server) error {
// Note we use the background context here as ctx has been canceled already
shutdownCtx, shutdownCancel := context.WithTimeout(context.Background(), 5*time.Second)
shutdownErr := srv.Shutdown(shutdownCtx) //nolint:contextcheck
func shutdownServer(ctx context.Context, srv *http.Server) error {
shutdownCtx, shutdownCancel := context.WithTimeout(context.WithoutCancel(ctx), 5*time.Second)
shutdownErr := srv.Shutdown(shutdownCtx)
shutdownCancel()
if shutdownErr != nil {
// Log the error only (could be context canceled)