sendnrw/pocket-id
2
0
Fork 0
mirror of https://github.com/pocket-id/pocket-id.git synced 2026-05-19 19:39:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make stream of downloaded logos seekable for S3 checksum calculation

Browse Source
This commit is contained in:
Elias Schneider
2026-05-19 16:28:30 +02:00
parent b27a52a591
commit cc9163f577
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
backend/internal/service/oidc_service.go
View File

@@ -1,6 +1,7 @@
package service
import (
"bytes"
"context"
"crypto/sha256"
"crypto/subtle"
@@ -2154,11 +2155,20 @@ func (s *OidcService) downloadAndSaveLogoFromURL(parentCtx context.Context, clie
darkSuffix = "-dark"
}
imagePath := path.Join("oidc-client-images", clientID+darkSuffix+"."+ext)
err = s.fileStorage.Save(ctx, imagePath, utils.NewLimitReader(resp.Body, maxLogoSize+1))
// Buffer the body so that storage backends receive a seekable reader with a known content length,
// which is required for correct checksum calculation on S3-compatible services
limitedBody := utils.NewLimitReader(resp.Body, maxLogoSize+1)
buf, err := io.ReadAll(limitedBody)
if errors.Is(err, utils.ErrSizeExceeded) {
return errLogoTooLarge
} else if err != nil {
if errors.Is(err, utils.ErrSizeExceeded) {
return errLogoTooLarge
} else if err != nil {
return err
}
}
imagePath := path.Join("oidc-client-images", clientID+darkSuffix+"."+ext)
if err = s.fileStorage.Save(ctx, imagePath, bytes.NewReader(buf)); err != nil {
return err
}