mirror of
https://github.com/netbirdio/netbird.git
synced 2026-09-12 17:59:06 +02:00
riccardom
55791332f3
FailedPrecondition reached the classifier unmatched, so a refusal showed as "Operation failed". It is the code both of the daemon's deliberate refusals carry: the update-settings kill switch, and a field an MDM policy manages. Both are now named — settings_locked and settings_managed_by_mdm, matched on the message the daemon composes — and FailedPrecondition itself falls back to change_refused, so a refusal the daemon grows later still reads as a refusal rather than a failure. Only the English strings are added. Bundle.Translate falls back to the default language for a missing key, so other locales show English until the usual translation pass, rather than the bare "error.<code>" the classifier would otherwise surface. Note: the package needs GTK4/WebKit to build, which this machine has not, so the test is type-checked (go vet, GOOS=windows) but was not executed locally; CI's Linux job runs it.
73 lines
2.5 KiB
Go
73 lines
2.5 KiB
Go
//go:build !android && !ios && !freebsd && !js
|
|
|
|
package services
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
gcodes "google.golang.org/grpc/codes"
|
|
gstatus "google.golang.org/grpc/status"
|
|
)
|
|
|
|
func TestErrorClassifier_Classify(t *testing.T) {
|
|
c := errorClassifier{} // nil translator → Short is the bare "error.<code>" key
|
|
|
|
t.Run("permission denied by gRPC code with a clean desc", func(t *testing.T) {
|
|
// The daemon now forwards the innermost status: code + clean desc that
|
|
// no longer carries the English "permission denied" marker.
|
|
err := gstatus.Error(gcodes.PermissionDenied, "peer is already registered by a different User or a Setup Key")
|
|
|
|
ce := c.classify(err)
|
|
require.NotNil(t, ce)
|
|
require.Equal(t, "permission_denied", ce.Code)
|
|
require.Equal(t, "error.permission_denied", ce.Short)
|
|
require.Equal(t, "peer is already registered by a different User or a Setup Key", ce.Long)
|
|
})
|
|
|
|
t.Run("substring match still wins for unclassified codes", func(t *testing.T) {
|
|
err := gstatus.Error(gcodes.Unknown, "peer login has expired")
|
|
|
|
ce := c.classify(err)
|
|
require.NotNil(t, ce)
|
|
require.Equal(t, "session_expired", ce.Code)
|
|
})
|
|
|
|
t.Run("the update-settings kill switch is a refusal, not a failure", func(t *testing.T) {
|
|
err := gstatus.Error(gcodes.FailedPrecondition,
|
|
"update settings are disabled, you cannot use this feature without update settings enabled")
|
|
|
|
ce := c.classify(err)
|
|
require.NotNil(t, ce)
|
|
require.Equal(t, "settings_locked", ce.Code)
|
|
})
|
|
|
|
t.Run("an MDM-managed field is named as such", func(t *testing.T) {
|
|
err := gstatus.Error(gcodes.FailedPrecondition,
|
|
"fields managed by MDM cannot be modified: [managementURL]")
|
|
|
|
require.Equal(t, "settings_managed_by_mdm", c.classify(err).Code)
|
|
})
|
|
|
|
t.Run("any other refusal is still a refusal", func(t *testing.T) {
|
|
// FailedPrecondition means the daemon answered and declined; falling
|
|
// through to "unknown" showed "Operation failed" instead.
|
|
require.Equal(t, "change_refused", c.classify(gstatus.Error(gcodes.FailedPrecondition, "something else")).Code)
|
|
})
|
|
|
|
t.Run("unavailable code maps to daemon_unreachable", func(t *testing.T) {
|
|
ce := c.classify(gstatus.Error(gcodes.Unavailable, "transport closing"))
|
|
require.Equal(t, "daemon_unreachable", ce.Code)
|
|
})
|
|
|
|
t.Run("unmatched stays unknown", func(t *testing.T) {
|
|
ce := c.classify(errors.New("something odd"))
|
|
require.Equal(t, "unknown", ce.Code)
|
|
})
|
|
|
|
t.Run("nil error", func(t *testing.T) {
|
|
require.Nil(t, c.classify(nil))
|
|
})
|
|
}
|