Commit Graph

3313 Commits

Author SHA1 Message Date
riccardom
a06cbd42d6 Prioritize Kem over RP 2026-08-27 12:19:34 +02:00
riccardom
80bbdf13cb pqkem: concurrency tests (recovery + race)
- RecoversViaResignalAfterDataPathBreak: a data-path rotation that can no longer
  converge raises OnRekeyFailed, and re-bootstrapping over signalling resyncs both
  peers on a fresh PSK even while the data path stays broken.
- ConcurrentRekeysNoRace: hammers the single-lock state machine with concurrent
  rotation clocks from many goroutines (run with -race) and asserts no split-brain
  via a final deterministic bootstrap.
2026-08-27 12:19:34 +02:00
riccardom
57d3e07f18 pqkem: recover from persistent rekey failure by re-bootstrapping over signal
OnRekeyFailed now re-runs the KEM bootstrap over Signal (conn.RequestReoffer ->
handshaker.SendOffer) instead of only logging: a fresh signalling offer starts a new
exchange that overwrites the stalled PSK on both sides, resyncing after a persistent
data-path desync. Chosen over a responder-side awaitingAck revert (which fights the
confirm-less ack timing) and a full tunnel teardown (heavier). The tunnel stays up on
the previous PSK meanwhile since Signal is independent of the broken data path.
2026-08-27 12:19:34 +02:00
riccardom
85f1a6f69f Discriminate initial from rekey failure 2026-08-27 12:19:34 +02:00
riccardom
9908106f4b pqkem: strict (fail-closed) mode + wire status Quantum resistance
Strict mode (NB_PQ_MLKEM_STRICT, default off) closes the initial PQ-vulnerable
window (NET-1408): when enabled, conn.presharedKey programs a per-conn random
sentinel PSK until the ML-KEM exchange derives the real one, so no session can form
on a non-PQ key (the real PSK is pushed via SetPresharedKey once it converges).
Default stays opportunistic.

Also surface PQ status: the peer 'Quantum resistance' flag (RosenpassEnabled) is now
true when an ML-KEM PSK has been derived for the peer, not only for Rosenpass.
2026-08-27 12:19:34 +02:00
riccardom
3676b9de20 pqkem: rotate PSK in kernel mode instead of skipping
The idle-gate reads LastActivities, which only tracks per-peer data in userspace;
in kernel mode it is empty, so the gate treated every kernel peer as idle and
disabled data-path rotation entirely. Detect the bind via IsUserspaceBind and, in
kernel mode, report zero activity age (always 'active') so rotation runs on every
rekey. Lazy back-to-idle is already limited in kernel; the eBPF WG-activity
detection will later supply a real signal that excludes handshake/pqkem traffic.
2026-08-27 12:19:34 +02:00
riccardom
156f660333 pqkem: derive PSK with HKDF-SHA256
Replace the raw SHA-256 concat combiner with HKDF-SHA256 (crypto/hkdf, Go 1.24):
IKM = ML-KEM_ss || X25519_ss (draft-ietf-tls-ecdhe-mlkem order), salt = the
domain-separation label, info = full transcript (offer || answer) || canonicalised
peer identities. Keeps the transcript + identity binding while using a proper KDF.
2026-08-27 12:19:34 +02:00
riccardom
edc17965d0 Don't rotate PQ keys if data path is idle for ~90s (less than a WG handhshake time 2026-08-27 12:19:34 +02:00
riccardom
57f7378ade Adds log tracepoints
- Add a trace slog level (NB_PQ_MLKEM_LOG_LEVEL=trace) and move the verbose
  per-exchange lifecycle logs (offer/answer/PSK/ack/rotation) to it, so debug
  stays quiet and troubleshooting is opt-in.
- Stop logging the raw preshared key; drop the temporary pqkem-dbg OnRemoteOffer/
  OnRemoteAnswer probes.
- Demote the per-handshake conn log to trace.
2026-08-27 12:18:58 +02:00
riccardom
22b40ad2eb Renames SetRemotePort to SetRemoteAddr 2026-08-27 12:18:07 +02:00
riccardom
ec2d6c9004 pqkem: clock data-path PSK rotation from WireGuard handshakes
Source OnDataPathRekeyed from the WGWatcher's per-handshake callback
(onWGCheckSuccess), which fires only on a fresh handshake, and OnDataPathDown
from the handshake-timeout path. A fresh handshake clocks the next chained
KEM exchange pushed over the data-path UDP transport.
2026-08-27 12:18:07 +02:00
riccardom
c49666c859 pqkem: register data-path endpoint from signalling
Learn the peer's data-path endpoint from the signalling offer/answer: its WG
overlay IP combined with the advertised pq UDP port (SetRemotePort -> AddPeer).
Registering here is safe before the tunnel is up because sends only ever fire
once it is (clocked by OnDataPathRekeyed). RemovePeer is wired at peer teardown
(engine.removePeer), not on transient disconnect.
2026-08-27 12:18:07 +02:00
riccardom
5fabb87b02 pqkem: apply derived PSK at WG peer-config time (pull) + keep push for rekey 2026-08-27 12:18:07 +02:00
riccardom
2400eaa246 pqkem: carry KEM offer/answer over the signalling exchange 2026-08-27 12:18:07 +02:00
riccardom
850d35b896 pqkem: dedicated slog logger via NB_PQ_MLKEM_LOG_LEVEL 2026-08-27 12:18:07 +02:00
riccardom
b861d57856 Homogeneous logs prefix 2026-08-27 12:18:07 +02:00
riccardom
d255b53279 Bit of renaming
peer -> peerAddrs
have types for remoteID and localID
t.Close log error
Manager SetTransport -> Start
2026-08-27 12:18:07 +02:00
riccardom
3e188eaf13 Typo 2026-08-27 12:18:07 +02:00
riccardom
8f9e18aa31 Race fix 2026-08-27 12:18:07 +02:00
riccardom
11f8409354 Makes Transport just a UDP socket.
Manager owns maps for remoteID <-> remote UDP addr
Engine talks to manager only
2026-08-27 12:18:07 +02:00
riccardom
bf7ed45ca9 Adds transport 2026-08-27 12:18:07 +02:00
riccardom
e1f91d02ee Communicate the port over the signal exchange 2026-08-27 12:18:07 +02:00
riccardom
3bdf2db52f Ensure iface is up and with overlay ip assigned to get a valid UDP port 2026-08-27 12:18:07 +02:00
riccardom
07c5ac6bac Adds real callback setter for PSK on ready 2026-08-27 12:18:07 +02:00
riccardom
dc9ea94c61 Initializes PQ ML-KEM manager 2026-08-27 12:18:07 +02:00
riccardom
87a3f1e056 Adds no-op Transports and callbacks 2026-08-27 12:18:07 +02:00
riccardom
3da87de12a Added enabled env var 2026-08-27 12:18:07 +02:00
riccardom
87fbf0ac26 Adds MLKEM Payload placeholder to client internals 2026-08-27 12:18:07 +02:00
riccardom
1cab588bc0 Invert order of keys as per draft 2026-08-27 12:18:07 +02:00
riccardom
d29faa7f46 Protocol update 2026-08-27 12:18:07 +02:00
riccardom
a8350c77f8 Removes confirm. Uses next offer to deliver confirmation/ack of previous round
We clock the next Offer initiation to the OnDataPathRekeyed, so we have 2 minutes
ahead of us to do our attempts and stuff before to give up.
On failure, we will know because we will not receive a new answer.. but more importantly
the wg handshake will fail :D
2026-08-27 12:18:07 +02:00
riccardom
6f6fdfff4d Leave signal offer/answer as a pull/push operation not as an actual transport 2026-08-27 12:18:07 +02:00
riccardom
65948ca76d Assume two transports: initial "signal" (control plane) one (no data path established yet) + data path one
Define OnDataPathRekeyed event to transition from control plane path to data plane path over the WG tunnel.

Keep confirm ALWAYS on NEW established WG tunnel (posthandshake with rekeying). We keep an active method
irrelevant of the WG handshake (we might decide that the indirect wg handshake is sufficient in the future).

Optimistic commit on responder(when sending answer), while on initiator we set it on getting the answer
2026-08-27 12:18:07 +02:00
riccardom
da6a56a7ef Epurate wg refs 2026-08-27 12:18:07 +02:00
riccardom
4582c5b4fc Collapse Driver and Manager in one.
- Have just one manager => one lock
 - Session state is needed in driver to => we have it available now.
 - Isomorphically align to rosenpass components and functionality

File	Role	                                  rosenpass equivalent
kem.go	primitive pure X25519MLKEM768	          crypto.go/handshake
message.go	Offer/Answer/Confirm + Encode/Decode  messages.go
manager.go	Manager stateful, single lock	      server logic
callbacks.go	WGCallbackHandler (seam output)	  Handler
Transport (interfaccia)	seam trasporto pluggable  Conn
2026-08-27 12:18:07 +02:00
riccardom
5eea1b1c8e [squash] isInitial and answered can be inferred without state variables 2026-08-27 12:18:07 +02:00
riccardom
b92f7c54d0 Manages convergence 2026-08-27 12:18:07 +02:00
riccardom
0cf67417f9 Models reattempts 2026-08-27 12:18:07 +02:00
riccardom
f66b94be07 Reuse answer, don't calculate again 2026-08-27 12:18:07 +02:00
riccardom
7cb08f7282 Adds driver to glue together manager and outside world 2026-08-27 12:18:07 +02:00
riccardom
33734635bf Defines event callbacks 2026-08-27 12:18:07 +02:00
riccardom
1d7acada1c Admits possible errors on Encode 2026-08-27 12:18:07 +02:00
riccardom
bfcc8aaa94 Bench key material boilerplate time/allocs
CGO_ENABLED=1 go test ./client/internal/pqkem/ -run '^$' -bench . -benchmem 2>&1 | grep -E "Benchmark|ns/op|PASS|ok" | head -20

BenchmarkX25519Keygen-14    	   33795	     34966 ns/op	     224 B/op	       5 allocs/op
BenchmarkX25519ECDH-14      	   33855	     33973 ns/op	      32 B/op	       1 allocs/op
BenchmarkMLKEMKeygen-14     	   21817	     67778 ns/op	    8200 B/op	       2 allocs/op
BenchmarkMLKEMEncaps-14     	   29918	     43235 ns/op	    1216 B/op	       2 allocs/op
BenchmarkMLKEMDecaps-14     	   26048	     56291 ns/op	      64 B/op	       2 allocs/op
PASS
ok  	github.com/netbirdio/netbird/client/internal/pqkem	9.751s
Shell cwd was reset to /home/riccardo/Desktop/Personal/netbirdio/netbird
2026-08-27 12:18:07 +02:00
riccardom
59a23d706a Pure mechanics of manager 2026-08-27 12:18:07 +02:00
riccardom
045678c184 Messages definition 2026-08-27 12:18:07 +02:00
riccardom
cb9f8f75e6 ML-KEM encapsulate/decapsulate module 2026-08-27 12:18:07 +02:00
Viktor Liu
473392a935 [client] Tolerate a still-locked updater binary when cleaning up after an update (#7286) 2026-08-26 20:03:56 +02:00
Viktor Liu
0bd1147ff0 [client] Keep NetBird traffic out of third-party fwmark rules (#7314) 2026-08-26 20:03:40 +02:00
Viktor Liu
f221347c7a [infrastructure] Trigger the dashboard wasm client bump on release tags (#7277) 2026-08-26 15:34:10 +02:00
dmitri-netbird
0a9ce7f797 [client] fix a flake in TestResolver_ConcurrentStaleHitsCollapseRefresh test (#7326)
* fix a flake in TestResolver_ConcurrentStaleHitsCollapseRefresh test

Signed-off-by: Dmitri Dolguikh <dmitri.external@netbird.io>

* use testify's eventually asserts

Signed-off-by: Dmitri Dolguikh <dmitri.external@netbird.io>

---------

Signed-off-by: Dmitri Dolguikh <dmitri.external@netbird.io>
2026-08-26 12:51:19 +02:00