sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-09-19 21:29:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Compare the resolved principal, not its string form, in the Windows tests

Browse Source
This commit is contained in:
Viktor Liu
2026-09-09 11:27:42 +02:00
parent 2064b2a0bd
commit ed63bf71dd
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/cmd/service_allow_group_windows_test.go
+5 -2
View File
@@ -9,6 +9,8 @@ import (
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require" "github.com/stretchr/testify/require"
"golang.org/x/sys/windows" "golang.org/x/sys/windows"
"github.com/netbirdio/netbird/client/internal/ipcauth"
) )
// accountName returns the name the local system knows a SID by. // accountName returns the name the local system knows a SID by.
@@ -39,7 +41,8 @@ func TestResolveAllowGroup_SID(t *testing.T) {
t.Run(value, func(t *testing.T) { t.Run(value, func(t *testing.T) {
principal, err := resolveAllowGroup(value) principal, err := resolveAllowGroup(value)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, "sid:"+sidAdministrators, principal) assert.Equal(t, ipcauth.KindSID, principal.Kind)
assert.Equal(t, "sid:"+sidAdministrators, principal.String())
}) })
} }
} }
@@ -52,7 +55,7 @@ func TestResolveAllowGroup_ByName(t *testing.T) {
principal, err := resolveAllowGroup(name) principal, err := resolveAllowGroup(name)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, "sid:"+sidAdministrators, principal) assert.Equal(t, "sid:"+sidAdministrators, principal.String())
} }
func TestResolveAllowGroup_Rejects(t *testing.T) { func TestResolveAllowGroup_Rejects(t *testing.T) {