From ed63bf71ddcd50f1bbd9d7e4f7a2db65f28a4fea Mon Sep 17 00:00:00 2001 From: Viktor Liu Date: Wed, 9 Sep 2026 11:27:42 +0200 Subject: [PATCH] Compare the resolved principal, not its string form, in the Windows tests --- client/cmd/service_allow_group_windows_test.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/client/cmd/service_allow_group_windows_test.go b/client/cmd/service_allow_group_windows_test.go index b147f6383..ac36b7d4d 100644 --- a/client/cmd/service_allow_group_windows_test.go +++ b/client/cmd/service_allow_group_windows_test.go @@ -9,6 +9,8 @@ import ( "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "golang.org/x/sys/windows" + + "github.com/netbirdio/netbird/client/internal/ipcauth" ) // accountName returns the name the local system knows a SID by. @@ -39,7 +41,8 @@ func TestResolveAllowGroup_SID(t *testing.T) { t.Run(value, func(t *testing.T) { principal, err := resolveAllowGroup(value) require.NoError(t, err) - assert.Equal(t, "sid:"+sidAdministrators, principal) + assert.Equal(t, ipcauth.KindSID, principal.Kind) + assert.Equal(t, "sid:"+sidAdministrators, principal.String()) }) } } @@ -52,7 +55,7 @@ func TestResolveAllowGroup_ByName(t *testing.T) { principal, err := resolveAllowGroup(name) require.NoError(t, err) - assert.Equal(t, "sid:"+sidAdministrators, principal) + assert.Equal(t, "sid:"+sidAdministrators, principal.String()) } func TestResolveAllowGroup_Rejects(t *testing.T) {