sendnrw/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-09-14 18:59:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

[client] Stop documenting a missing published destination as an upload failure

Browse Source 
WAILS-API.md listed "a deployment that publishes no upload service" among the
causes of uploadFailureReason. That was true of an earlier revision; the
resolver now falls back to the service NetBird runs, so the case never produces
a failure. Reserve the field for a destination that rejects the upload or cannot
be reached.

Reported by CodeRabbit on #7514.
This commit is contained in:
riccardom
2026-09-14 09:19:25 +02:00
parent 5c665c1399
commit d247bda54d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/ui/frontend/WAILS-API.md
+1 -1
View File
@@ -148,7 +148,7 @@ Debug.RevealFile(path: string): Promise<void> // OS file-manager focus
**Log level case sensitivity bug:** `proto.LogLevel_value` is keyed on uppercase enum names (`"TRACE"`, `"DEBUG"`, `"INFO"`, `"WARN"`, `"ERROR"`, `"PANIC"`, `"FATAL"`, `"UNKNOWN"`). `Debug.SetLogLevel` calls `proto.LogLevel_value[lvl.Level]` and falls back to `INFO` on miss. `useDebugBundle` currently passes `"trace"` (lowercase), which silently maps to `INFO` — the trace-capture flow doesn't actually raise the log level today. To raise to trace, pass `{ level: "TRACE" }`. Fix on the cleanup list.
`Debug.Bundle` uploads when `upload` is true; the daemon picks the destination from what the management server publishes, so the UI never names one. Result fields: `path` (local copy), `uploadedKey` (set on success), `uploadFailureReason` (set on upload failure, including a deployment that publishes no upload service — the local copy is still saved).
`Debug.Bundle` uploads when `upload` is true; the daemon picks the destination from what the management server publishes, falling back to the service NetBird runs when it publishes none, so the UI never names one. Result fields: `path` (local copy), `uploadedKey` (set on success), `uploadFailureReason` (set when the resolved destination rejects the upload or cannot be reached — the local copy is still saved).
## `Update`