sendnrw/netbird-docs
2
0
Fork 0
mirror of https://github.com/netbirdio/docs.git synced 2026-10-17 02:59:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

docs: fix mobile navigation offsets and contributor prerequisites

Browse Source
This commit is contained in:
PizzaLovingNerd
2026-09-10 20:21:30 -07:00
parent 1bef401e09
commit e4186068e9
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/MobileNavigation.jsx
+7 -2
View File
@@ -4,6 +4,7 @@ import { motion } from 'framer-motion'
import { create } from 'zustand'
import { Header } from '@/components/Header'
import { useAnnouncements } from '@/components/announcement-banner/AnnouncementBannerProvider'
import { NavigationAPI } from '@/components/NavigationAPI'
import {NavigationDocs} from "@/components/NavigationDocs";
import {useRouter} from "next/router";
@@ -52,6 +53,9 @@ export const useMobileNavigationStore = create((set) => ({
export function MobileNavigation() {
let isInsideMobileNavigation = useIsInsideMobileNavigation()
let { isOpen, toggle, close } = useMobileNavigationStore()
let { bannerHeight } = useAnnouncements()
// Match the fixed 64px header below the measured announcement banner.
let panelTop = bannerHeight + 64
let ToggleIcon = isOpen ? XIcon : MenuIcon
let router = useRouter()
@@ -78,7 +82,7 @@ export function MobileNavigation() {
leaveFrom="opacity-100"
leaveTo="opacity-0"
>
<div className="fixed inset-0 top-14 bg-zinc-400/20 backdrop-blur-sm dark:bg-[#181A1D]/40" />
<div style={{ top: panelTop }} className="fixed inset-0 bg-zinc-400/20 backdrop-blur-sm dark:bg-[#181A1D]/40" />
</Transition.Child>
<Dialog.Panel>
@@ -105,7 +109,8 @@ export function MobileNavigation() {
>
<motion.div
layoutScroll
className="fixed bottom-0 left-0 top-14 w-full overflow-y-auto bg-white/70 dark:bg-[#181A1D]/95 backdrop-blur-lg px-4 pb-4 pt-6 shadow-lg shadow-zinc-900/10 ring-1 ring-zinc-900/7.5 dark:ring-neutral-500/10 min-[416px]:max-w-sm sm:px-6 sm:pb-10"
style={{ top: panelTop }}
className="fixed bottom-0 left-0 w-full overflow-y-auto bg-white/70 dark:bg-[#181A1D]/95 backdrop-blur-lg px-4 pb-4 pt-6 shadow-lg shadow-zinc-900/10 ring-1 ring-zinc-900/7.5 dark:ring-neutral-500/10 min-[416px]:max-w-sm sm:px-6 sm:pb-10"
>
{router.route.startsWith("/ipa") ? <NavigationAPI tableOfContents={[]} /> :
<NavigationDocs />}
src/pages/contribute/development.mdx
+3 -3
View File
@@ -52,7 +52,7 @@ make lint-all
make test-unit
```
`make lint` checks files changed against `origin/main`; `make lint-all` runs the full-repository linter used by CI. `make test-unit` is the host-safe suite and runs without changing host networking.
`make lint` checks files changed against `origin/main`; `make lint-all` runs the full-repository linter used by CI. `make test-unit` is the host-safe suite and runs without changing host networking. It includes the desktop UI package, whose Go code embeds `client/ui/frontend/dist`. On a fresh checkout, complete the [Desktop UI](#desktop-ui) prerequisites and build before running the broad suite; a missing `frontend/dist` error means the assets have not been generated. For a service-only change, start with that service's package tests.
For firewall, routing, interface management, and other privileged networking paths, run the contained privileged suite:
@@ -60,7 +60,7 @@ For firewall, routing, interface management, and other privileged networking pat
make test-privileged
```
That target selects tests carrying the `privileged` build tag and runs them in a Docker container with elevated networking capabilities. It needs Docker and can take longer than the unit suite. Narrow runs with `PRIV_RUN` and `PRIV_PKGS` only as documented in the core contribution guide.
That target selects tests carrying the `privileged` build tag and runs them in a Docker container with elevated networking capabilities. It needs Docker and can take longer than the unit suite. Run it in a disposable VM with its own Go caches: the container can write root-owned files into bind-mounted caches, causing later host-side tests to fail with permission errors. Narrow runs with `PRIV_RUN` and `PRIV_PKGS` only as documented in the core contribution guide.
Build or test an individual component when it gives faster feedback:
@@ -80,7 +80,7 @@ Packages that use build tags, elevated privileges, concurrency, or operating-sys
## Desktop UI
The desktop application is built from `client/ui` in the core repository. Its current `Taskfile.yml` dispatches platform-specific Wails v3 builds.
The desktop application is built from `client/ui` in the core repository. Its current `Taskfile.yml` dispatches platform-specific Wails v3 builds. Install Node.js, pnpm, the `wails3` CLI, and the `task` runner using the core repository's [UI prerequisites](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#ui-client---wails-v3--react). Linux builds also require the WebKitGTK 6.0, GTK 4, and libsoup 3 development packages.
```bash
cd client/ui