pangolin_mirror/pangolin
1
0
Fork 0
mirror of https://github.com/fosrl/pangolin.git synced 2026-10-28 06:29:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3922 from Tyagiquamar/fix/blueprint-basic-auth-race-3835

Browse Source 
fix(blueprints): hash basic-auth before header-auth delete
This commit is contained in:
Owen Schwartz
2026-10-27 15:27:06 -04:00
committed by GitHub
parent efa2acf340 9a89ff48a8
commit 5f68236f49
1 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/lib/blueprints/resourcePolicies.ts
+18 -9
View File
@@ -182,15 +182,7 @@ export async function updateResourcePolicies(
});
}
// Sync header auth
await trx
.delete(resourcePolicyHeaderAuth)
.where(
eq(
resourcePolicyHeaderAuth.resourcePolicyId,
resourcePolicyId
)
);
// Sync header auth (hash before delete so delete+insert stay adjacent)
if (policyData["basic-auth"]) {
const basicAuth = policyData["basic-auth"];
const headerAuthHash = await hashPassword(
@@ -198,12 +190,29 @@ export async function updateResourcePolicies(
`${basicAuth.user}:${basicAuth.password}`
).toString("base64")
);
await trx
.delete(resourcePolicyHeaderAuth)
.where(
eq(
resourcePolicyHeaderAuth.resourcePolicyId,
resourcePolicyId
)
);
await trx.insert(resourcePolicyHeaderAuth).values({
resourcePolicyId,
headerAuthHash,
extendedCompatibility:
basicAuth["extended-compatibility"] ?? true
});
} else {
await trx
.delete(resourcePolicyHeaderAuth)
.where(
eq(
resourcePolicyHeaderAuth.resourcePolicyId,
resourcePolicyId
)
);
}
// Sync SSO roles