fix: remove duplicate wrong error log in socket/fetch handler and dead code in reliablePing

Former-commit-id: d57b7ccb53

common.go

@@ -121,19 +121,11 @@ func reliablePing(tnet *netstack.Net, dst string, baseTimeout time.Duration, max
 		totalLatency += latency
 		successCount++
 
-		// If we get at least one success, we can return early for health checks
-		if successCount > 0 {
-			avgLatency := totalLatency / time.Duration(successCount)
-			// logger.Debug("Reliable ping succeeded after %d attempts, avg latency: %v", attempt, avgLatency)
-			return avgLatency, nil
-		}
+		// Return on first success
+		return totalLatency / time.Duration(successCount), nil
 	}
 
-	if successCount == 0 {
-		return 0, fmt.Errorf("all %d ping attempts failed, last error: %v", maxAttempts, lastErr)
-	}
-
-	return totalLatency / time.Duration(successCount), nil
+	return 0, fmt.Errorf("all %d ping attempts failed, last error: %v", maxAttempts, lastErr)
 }
 
 func pingWithRetry(tnet *netstack.Net, dst string, timeout time.Duration) (stopChan chan struct{}, err error) {

main.go

@@ -1482,10 +1482,6 @@ persistent_keepalive_interval=5`, util.FixKey(privateKey.String()), util.FixKey(
 		err = client.SendMessage("newt/socket/containers", map[string]interface{}{
 			"containers": containers,
 		})
-		if err != nil {
-			logger.Error("Failed to send registration message: %v", err)
-		}
-
 		if err != nil {
 			logger.Error("Failed to send Docker container list: %v", err)
 		} else {