refactor: Revise duplicate flow controller tests

This commit is contained in:
Faruk AYDIN
2024-09-17 13:18:48 +03:00
parent c6003b6695
commit bf6ff6b0f7

View File

@@ -29,7 +29,7 @@ describe('POST /api/v1/flows/:flowId/duplicate', () => {
key: 'catchRawWebhook',
});
const actionStep = await createStep({
await createStep({
flowId: currentUserFlow.id,
type: 'action',
appKey: 'ntfy',
@@ -72,71 +72,8 @@ describe('POST /api/v1/flows/:flowId/duplicate', () => {
refetchedDuplicateFlowSteps
);
const refetchedDuplicateFlowTriggerStep = refetchedDuplicateFlowSteps[0];
const refetchedDuplicateFlowActionStep = refetchedDuplicateFlowSteps[1];
expect(response.body).toStrictEqual(expectedPayload);
expect(refetchedDuplicateFlow.userId).toStrictEqual(currentUser.id);
expect(refetchedDuplicateFlowSteps.length).toStrictEqual(2);
expect(refetchedDuplicateFlowTriggerStep.appKey).toStrictEqual(
triggerStep.appKey
);
expect(refetchedDuplicateFlowTriggerStep.key).toStrictEqual(
triggerStep.key
);
expect(refetchedDuplicateFlowTriggerStep.connectionId).toStrictEqual(
triggerStep.connectionId
);
expect(refetchedDuplicateFlowTriggerStep.position).toStrictEqual(
triggerStep.position
);
expect(refetchedDuplicateFlowTriggerStep.parameters).toStrictEqual(
triggerStep.parameters
);
expect(refetchedDuplicateFlowTriggerStep.type).toStrictEqual(
triggerStep.type
);
expect(refetchedDuplicateFlowActionStep.appKey).toStrictEqual(
actionStep.appKey
);
expect(refetchedDuplicateFlowActionStep.key).toStrictEqual(actionStep.key);
expect(refetchedDuplicateFlowActionStep.connectionId).toStrictEqual(
actionStep.connectionId
);
expect(refetchedDuplicateFlowActionStep.position).toStrictEqual(
actionStep.position
);
expect(refetchedDuplicateFlowActionStep.parameters.topic).toStrictEqual(
actionStep.parameters.topic
);
expect(refetchedDuplicateFlowActionStep.parameters.message).toStrictEqual(
actionStep.parameters.message.replaceAll(
`{{step.${triggerStep.id}.`,
`{{step.${refetchedDuplicateFlowTriggerStep.id}.`
)
);
expect(refetchedDuplicateFlowActionStep.type).toStrictEqual(
actionStep.type
);
expect(refetchedDuplicateFlowTriggerStep.webhookPath).toStrictEqual(
`/webhooks/flows/${refetchedDuplicateFlow.id}`
);
});
it('should return duplicated flow data of another user', async () => {
@@ -150,7 +87,7 @@ describe('POST /api/v1/flows/:flowId/duplicate', () => {
key: 'catchRawWebhook',
});
const actionStep = await createStep({
await createStep({
flowId: anotherUserFlow.id,
type: 'action',
appKey: 'ntfy',
@@ -193,71 +130,8 @@ describe('POST /api/v1/flows/:flowId/duplicate', () => {
refetchedDuplicateFlowSteps
);
const refetchedDuplicateFlowTriggerStep = refetchedDuplicateFlowSteps[0];
const refetchedDuplicateFlowActionStep = refetchedDuplicateFlowSteps[1];
expect(response.body).toStrictEqual(expectedPayload);
expect(refetchedDuplicateFlow.userId).toStrictEqual(currentUser.id);
expect(refetchedDuplicateFlowSteps.length).toStrictEqual(2);
expect(refetchedDuplicateFlowTriggerStep.appKey).toStrictEqual(
triggerStep.appKey
);
expect(refetchedDuplicateFlowTriggerStep.key).toStrictEqual(
triggerStep.key
);
expect(refetchedDuplicateFlowTriggerStep.connectionId).toStrictEqual(
triggerStep.connectionId
);
expect(refetchedDuplicateFlowTriggerStep.position).toStrictEqual(
triggerStep.position
);
expect(refetchedDuplicateFlowTriggerStep.parameters).toStrictEqual(
triggerStep.parameters
);
expect(refetchedDuplicateFlowTriggerStep.type).toStrictEqual(
triggerStep.type
);
expect(refetchedDuplicateFlowActionStep.appKey).toStrictEqual(
actionStep.appKey
);
expect(refetchedDuplicateFlowActionStep.key).toStrictEqual(actionStep.key);
expect(refetchedDuplicateFlowActionStep.connectionId).toStrictEqual(
actionStep.connectionId
);
expect(refetchedDuplicateFlowActionStep.position).toStrictEqual(
actionStep.position
);
expect(refetchedDuplicateFlowActionStep.parameters.topic).toStrictEqual(
actionStep.parameters.topic
);
expect(refetchedDuplicateFlowActionStep.parameters.message).toStrictEqual(
actionStep.parameters.message.replaceAll(
`{{step.${triggerStep.id}.`,
`{{step.${refetchedDuplicateFlowTriggerStep.id}.`
)
);
expect(refetchedDuplicateFlowActionStep.type).toStrictEqual(
actionStep.type
);
expect(refetchedDuplicateFlowTriggerStep.webhookPath).toStrictEqual(
`/webhooks/flows/${refetchedDuplicateFlow.id}`
);
});
it('should return not found response for not existing flow UUID', async () => {