groot/automatisch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1142 from automatisch/fix-twilio-receive-sms-test-run

Browse Source 
fix(twilio/receive-sms): use phone number via phone number sid
This commit is contained in:
Ömer Faruk Aydın
2023-06-14 13:42:11 +02:00
committed by GitHub
parent 59844c33fd 63251e6a9a
commit 92638c2e97
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/backend/src/apps/twilio/common/get-incoming-phone-number.ts Normal file
View File

@@ -0,0 +1,14 @@
import { IGlobalVariable } from "@automatisch/types";
type Response = {
sid: string;
phone_number: string;
};
export default async function getIncomingPhoneNumber($: IGlobalVariable) {
const phoneNumberSid = $.step.parameters.phoneNumberSid as string;
const path = `/2010-04-01/Accounts/${$.auth.data.accountSid}/IncomingPhoneNumbers/${phoneNumberSid}.json`;
const response = await $.http.get<Response>(path);
return response.data;
};

5
packages/backend/src/apps/twilio/triggers/receive-sms/fetch-messages.ts
View File

@@ -1,10 +1,11 @@
import { IGlobalVariable, IJSONObject } from '@automatisch/types'; import { IGlobalVariable, IJSONObject } from '@automatisch/types';
import getIncomingPhoneNumber from '../../common/get-incoming-phone-number';
const fetchMessages = async ($: IGlobalVariable) => { const fetchMessages = async ($: IGlobalVariable) => {
const toNumber = $.step.parameters.toNumber as string; const incomingPhoneNumber = await getIncomingPhoneNumber($);
let response; let response;
let requestPath = `/2010-04-01/Accounts/${$.auth.data.accountSid}/Messages.json?To=${toNumber}`; let requestPath = `/2010-04-01/Accounts/${$.auth.data.accountSid}/Messages.json?To=${incomingPhoneNumber.phone_number}`;
do { do {
response = await $.http.get(requestPath); response = await $.http.get(requestPath);