From 63251e6a9ada3ed1ab70edc022abb7743ebed678 Mon Sep 17 00:00:00 2001 From: Ali BARIN Date: Tue, 13 Jun 2023 21:26:51 +0000 Subject: [PATCH] fix(twilio/receive-sms): use phone number via phone number sid --- .../twilio/common/get-incoming-phone-number.ts | 14 ++++++++++++++ .../twilio/triggers/receive-sms/fetch-messages.ts | 5 +++-- 2 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 packages/backend/src/apps/twilio/common/get-incoming-phone-number.ts diff --git a/packages/backend/src/apps/twilio/common/get-incoming-phone-number.ts b/packages/backend/src/apps/twilio/common/get-incoming-phone-number.ts new file mode 100644 index 00000000..53abbe09 --- /dev/null +++ b/packages/backend/src/apps/twilio/common/get-incoming-phone-number.ts @@ -0,0 +1,14 @@ +import { IGlobalVariable } from "@automatisch/types"; + +type Response = { + sid: string; + phone_number: string; +}; + +export default async function getIncomingPhoneNumber($: IGlobalVariable) { + const phoneNumberSid = $.step.parameters.phoneNumberSid as string; + const path = `/2010-04-01/Accounts/${$.auth.data.accountSid}/IncomingPhoneNumbers/${phoneNumberSid}.json`; + const response = await $.http.get(path); + + return response.data; +}; diff --git a/packages/backend/src/apps/twilio/triggers/receive-sms/fetch-messages.ts b/packages/backend/src/apps/twilio/triggers/receive-sms/fetch-messages.ts index 974d3007..f6c7228a 100644 --- a/packages/backend/src/apps/twilio/triggers/receive-sms/fetch-messages.ts +++ b/packages/backend/src/apps/twilio/triggers/receive-sms/fetch-messages.ts @@ -1,10 +1,11 @@ import { IGlobalVariable, IJSONObject } from '@automatisch/types'; +import getIncomingPhoneNumber from '../../common/get-incoming-phone-number'; const fetchMessages = async ($: IGlobalVariable) => { - const toNumber = $.step.parameters.toNumber as string; + const incomingPhoneNumber = await getIncomingPhoneNumber($); let response; - let requestPath = `/2010-04-01/Accounts/${$.auth.data.accountSid}/Messages.json?To=${toNumber}`; + let requestPath = `/2010-04-01/Accounts/${$.auth.data.accountSid}/Messages.json?To=${incomingPhoneNumber.phone_number}`; do { response = await $.http.get(requestPath);