Merge pull request #476 from sll552/fix_domain_hostname

Fix cs collector crashing when running on a domain joined machine
2026-02-14 17:06:36 +00:00 · 2020-03-04 14:54:49 +01:00 · 2020-03-04 14:49:59 +01:00
1 changed files with 2 additions and 2 deletions
--- a/collector/cs.go
+++ b/collector/cs.go
@@ -67,7 +67,7 @@ type Win32_ComputerSystem struct {
 	TotalPhysicalMemory       uint64
 	DNSHostname               string
 	Domain                    string
-	Workgroup                 string
+	Workgroup                 *string
 }
 func (c *CSCollector) collect(ch chan<- prometheus.Metric) (*prometheus.Desc, error) {
@@ -93,7 +93,7 @@ func (c *CSCollector) collect(ch chan<- prometheus.Metric) (*prometheus.Desc, er
 	)
 	var fqdn string
-	if dst[0].Domain != dst[0].Workgroup {
+	if dst[0].Workgroup == nil || dst[0].Domain != *dst[0].Workgroup {
 		fqdn = dst[0].DNSHostname + "." + dst[0].Domain
 	} else {
 		fqdn = dst[0].DNSHostname
Author	SHA1	Message	Date
Calle Pettersson	890fdc2996	Merge pull request #476 from sll552/fix_domain_hostname Fix cs collector crashing when running on a domain joined machine	2020-03-04 14:54:49 +01:00
Stefan Lengauer	d1a807840c	Fix cs collector crashing when running on a domain joined machine The wmi lib does some type checking for nil values. Use a pointer as a workaround for that.	2020-03-04 14:49:59 +01:00