The IIS >= 8 metrics was updated two times by application and caused a fatal error. The purpose
of this fix is to update metrics one time by application.
Signed-off-by: Aymeric Daurelle <aymeric.daurelle@cdiscount.com>
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Reformat adfsCollector struct
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Add metrics to ADFS collector documentation
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector with useful queries and links to documentation
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Remove bad table formatter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Reformat ADFS collector using gofmt
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Fix ADFS Config and Artifact DB Query time metrics
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector for Config and Artifact DB Query time from gauge to counter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector for Config and Artifact DB Query time from gauge to counter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Loop was erroneously creating duplicate `windows_textfile_mtime_seconds`
metrics, causing the exporter to return a HTTP 500 error and no metrics
from any collector.
Signed-off-by: Ben Reedy <breed808@breed808.com>
Related to #659, this is a breaking change!
Fixes
```
windows_time_ntp_client_time_source_count non-histogram and non-summary metrics should not have "_count" suffix
```
for the time collector.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Related to #659, this is a breaking change!
Fixes
```
windows_process_handle_count non-histogram and non-summary metrics should not have "_count" suffix
windows_process_thread_count non-histogram and non-summary metrics should not have "_count" suffix
```
for process and terminal_services collectors.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
See,
```
$ GOOS=windows GOARCH=amd64 golangci-lint run ./... 2>1 | grep var-declaration
collector/os.go:205:22: var-declaration: should drop = 0 from declaration of var fsipf; it is the zero value (revive)
collector/os.go:226:23: var-declaration: should drop = 0 from declaration of var pfbRaw; it is the zero value (revive)
```
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Allows the following metrics to be exposed again, they had disappeared after the migration to perflib :
- worker_request_errors_total
- worker_current_websocket_requests
- worker_websocket_connection_accepted_total
- worker_websocket_connection_rejected_total
Signed-off-by: Souen Mazouin <souen.mazouin@cdiscount.com>
Some collectors were missed when migrating to the local
github.com/prometheus-community/windows_exporter/log library.
Signed-off-by: Ben Reedy <breed808@breed808.com>
Check all textfile metrics will be checked for duplicates. If duplicates
are detected, drop all metrics and log error.
Signed-off-by: Ben Reedy <breed808@breed808.com>
msmq collector would only collect from a hard-coded "Computer Queues"
queue.
Removal of filter allows other queues to be queried with
the collector.msmq.msmq-where flag.
Signed-off-by: Ben Reedy <breed808@breed808.com>
Benchmarks will allow for easier identification of slow collectors.
Additionally, they increase test coverage of the collectors, with some
collectors now reaching 80-95% coverage with this change.
Collector benchmarks have been structed so that common functionality is
present in `collector/collector_test.go` as is done with non-test
functionality in `collector/collector.go`.
Test logic that is specific to individual collectors is present in the
collector test file (E.G. `collector/process_test.go` for the Process
collector).
Signed-off-by: Ben Reedy <breed808@breed808.com>
- Defer registry close calls
- Ensure size parameter in GetComputerName is properly specified
- Clean up some comments to ensure correctness
Signed-off-by: Ben Ridley <benridley29@gmail.com>
