Inactive or missing paging file should not be cause for OS collector to
fail.
Instead, log the error and continue with OS collection.
Signed-off-by: Ben Reedy <breed808@breed808.com>
This change affects processing of single files with duplicate metrics.
Single files with duplicate metrics will be skipped, with no metrics being
collected and exposed by the exporter.
Previous duplicate metric processing across multiple files remains
unchanged (all files skipped, collector returns error).
Signed-off-by: Ben Reedy <breed808@breed808.com>
Remove "memory", which is redundant with the module and breaks symmetry
with vm_memory_physical_guest_visible.
Signed-off-by: Andrew Banman <abanman@pnri.org>
The IIS >= 8 metrics was updated two times by application and caused a fatal error. The purpose
of this fix is to update metrics one time by application.
Signed-off-by: Aymeric Daurelle <aymeric.daurelle@cdiscount.com>
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Reformat adfsCollector struct
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Add metrics to ADFS collector documentation
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector with useful queries and links to documentation
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Remove bad table formatter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Reformat ADFS collector using gofmt
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Fix ADFS Config and Artifact DB Query time metrics
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector for Config and Artifact DB Query time from gauge to counter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
Update ADFS collector for Config and Artifact DB Query time from gauge to counter
Signed-off-by: Austin D. Krauza <krauza.austin@gmail.com>
See,
```
windows_memory_demand_zero_faults_total non-counter metrics should not have "_total" suffix
windows_memory_cache_faults_total non-counter metrics should not have "_total" suffix
windows_memory_page_faults_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_bytes_total non-counter metrics should not have "_total" suffix
windows_memory_pool_paged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_operations_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_reads_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_writes_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_read_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_written_total non-counter metrics should not have "_total" suffix
windows_memory_transition_faults_total non-counter metrics should not have "_total" suffix
windows_memory_transition_pages_repurposed_total non-counter metrics should not have "_total" suffix
windows_memory_write_copies_total non-counter metrics should not have "_total" suffix
```
Only `windows_memory_pool_nonpaged_bytes` is a gauge, all the other
metrics were counters.
Also added some missing documentation.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Loop was erroneously creating duplicate `windows_textfile_mtime_seconds`
metrics, causing the exporter to return a HTTP 500 error and no metrics
from any collector.
Signed-off-by: Ben Reedy <breed808@breed808.com>
Related to #659, this is a breaking change!
Fixes
```
windows_time_ntp_client_time_source_count non-histogram and non-summary metrics should not have "_count" suffix
```
for the time collector.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Related to #659, this is a breaking change!
Fixes
```
windows_process_handle_count non-histogram and non-summary metrics should not have "_count" suffix
windows_process_thread_count non-histogram and non-summary metrics should not have "_count" suffix
```
for process and terminal_services collectors.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
See,
```
$ GOOS=windows GOARCH=amd64 golangci-lint run ./... 2>1 | grep var-declaration
collector/os.go:205:22: var-declaration: should drop = 0 from declaration of var fsipf; it is the zero value (revive)
collector/os.go:226:23: var-declaration: should drop = 0 from declaration of var pfbRaw; it is the zero value (revive)
```
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
