See,
```
windows_memory_demand_zero_faults_total non-counter metrics should not have "_total" suffix
windows_memory_cache_faults_total non-counter metrics should not have "_total" suffix
windows_memory_page_faults_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_pool_nonpaged_bytes_total non-counter metrics should not have "_total" suffix
windows_memory_pool_paged_allocs_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_operations_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_reads_total non-counter metrics should not have "_total" suffix
windows_memory_swap_page_writes_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_read_total non-counter metrics should not have "_total" suffix
windows_memory_swap_pages_written_total non-counter metrics should not have "_total" suffix
windows_memory_transition_faults_total non-counter metrics should not have "_total" suffix
windows_memory_transition_pages_repurposed_total non-counter metrics should not have "_total" suffix
windows_memory_write_copies_total non-counter metrics should not have "_total" suffix
```
Only `windows_memory_pool_nonpaged_bytes` is a gauge, all the other
metrics were counters.
Also added some missing documentation.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Resolves#911 which was introduced by 45e9357a.
This is due to the exporter only using the default port if no LISTEN_ADDR
**and** no LISTEN_PORT is defined.
Signed-off-by: Ben Reedy <breed808@breed808.com>
Loop was erroneously creating duplicate `windows_textfile_mtime_seconds`
metrics, causing the exporter to return a HTTP 500 error and no metrics
from any collector.
Signed-off-by: Ben Reedy <breed808@breed808.com>
Related to #659, this is a breaking change!
Fixes
```
windows_time_ntp_client_time_source_count non-histogram and non-summary metrics should not have "_count" suffix
```
for the time collector.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Related to #659, this is a breaking change!
Fixes
```
windows_process_handle_count non-histogram and non-summary metrics should not have "_count" suffix
windows_process_thread_count non-histogram and non-summary metrics should not have "_count" suffix
```
for process and terminal_services collectors.
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
See,
```
log/gokit_adapter.go:9:26: unexported-return: exported func NewToolkitAdapter returns unexported type *log.logAdapter, which can be annoying to use (revive)
func NewToolkitAdapter() *logAdapter {
^
```
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
See,
```
$ GOOS=windows GOARCH=amd64 golangci-lint run ./... 2>1 | grep var-declaration
collector/os.go:205:22: var-declaration: should drop = 0 from declaration of var fsipf; it is the zero value (revive)
collector/os.go:226:23: var-declaration: should drop = 0 from declaration of var pfbRaw; it is the zero value (revive)
```
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Explicit setting of listening port in the service definition causes port
setting in configuration file to be ignored.
Exporter already defines a default port (9812) if one is not specified,
so no impact from this change is anticipated.
Signed-off-by: Ben Reedy <breed808@breed808.com>
Allows the following metrics to be exposed again, they had disappeared after the migration to perflib :
- worker_request_errors_total
- worker_current_websocket_requests
- worker_websocket_connection_accepted_total
- worker_websocket_connection_rejected_total
Signed-off-by: Souen Mazouin <souen.mazouin@cdiscount.com>
Bot will submit PRs when new dependency versions are detected,
preventing dependencies from becoming out-of-date.
Signed-off-by: Ben Reedy <breed808@breed808.com>
