pdh: avoid reflection and per-scrape allocations when collecting (#2735)

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
2026-10-21 03:59:04 +02:00 · 2026-10-16 00:31:41 +02:00
parent 81ce8ef79d
commit f6aad2c284
6 changed files with 780 additions and 106 deletions
@@ -112,6 +112,9 @@ exercised a live Windows role.
  instance occurrences within a sample; their suffixes are not stable identities.
  Do not remove every name ending in `_Total`: legitimate process and database
  names can use that suffix. Use the shared aggregate-instance policy.
+  `pdh.Collector.Collect` reuses the backing array of its destination slice
+  and `Row.Values`; do not keep rows, sub-slices or pointers into it across
+  scrapes.
 - PDH collectors add counters by English path. On a Windows installation
  without en-US resources, the 009 name table holds localized names for v2
  (manifest-based) counter sets such as `SMB Server Shares` or `HTTP Service`;