sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-02-22 20:56:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

mssql: fix not collecting sql errors (#1793)

Browse Source 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This commit is contained in:
Jan-Otto Kröpke
2024-11-30 13:10:11 +01:00
committed by GitHub
parent 71e5e5ec5f
commit f5ff75ebc2
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/collector/mssql/mssql_sql_errors.go
View File

@@ -38,14 +38,14 @@ const (
func (c *Collector) buildSQLErrors() error { func (c *Collector) buildSQLErrors() error {
var err error var err error
c.genStatsPerfDataCollectors = make(map[string]*perfdata.Collector, len(c.mssqlInstances)) c.sqlErrorsPerfDataCollectors = make(map[string]*perfdata.Collector, len(c.mssqlInstances))
errs := make([]error, 0, len(c.mssqlInstances)) errs := make([]error, 0, len(c.mssqlInstances))
counters := []string{ counters := []string{
sqlErrorsErrorsPerSec, sqlErrorsErrorsPerSec,
} }
for sqlInstance := range c.mssqlInstances { for sqlInstance := range c.mssqlInstances {
c.genStatsPerfDataCollectors[sqlInstance], err = perfdata.NewCollector(c.mssqlGetPerfObjectName(sqlInstance, "SQL Errors"), perfdata.InstancesAll, counters) c.sqlErrorsPerfDataCollectors[sqlInstance], err = perfdata.NewCollector(c.mssqlGetPerfObjectName(sqlInstance, "SQL Errors"), perfdata.InstancesAll, counters)
if err != nil { if err != nil {
errs = append(errs, fmt.Errorf("failed to create SQL Errors collector for instance %s: %w", sqlInstance, err)) errs = append(errs, fmt.Errorf("failed to create SQL Errors collector for instance %s: %w", sqlInstance, err))
} }
@@ -63,7 +63,7 @@ func (c *Collector) buildSQLErrors() error {
} }
func (c *Collector) collectSQLErrors(ch chan<- prometheus.Metric) error { func (c *Collector) collectSQLErrors(ch chan<- prometheus.Metric) error {
return c.collect(ch, subCollectorSQLErrors, c.dbReplicaPerfDataCollectors, c.collectSQLErrorsInstance) return c.collect(ch, subCollectorSQLErrors, c.sqlErrorsPerfDataCollectors, c.collectSQLErrorsInstance)
} }
func (c *Collector) collectSQLErrorsInstance(ch chan<- prometheus.Metric, sqlInstance string, perfDataCollector *perfdata.Collector) error { func (c *Collector) collectSQLErrorsInstance(ch chan<- prometheus.Metric, sqlInstance string, perfDataCollector *perfdata.Collector) error {

4
internal/collector/mssql/mssql_sql_stats.go
View File

@@ -57,7 +57,7 @@ const (
func (c *Collector) buildSQLStats() error { func (c *Collector) buildSQLStats() error {
var err error var err error
c.genStatsPerfDataCollectors = make(map[string]*perfdata.Collector, len(c.mssqlInstances)) c.sqlStatsPerfDataCollectors = make(map[string]*perfdata.Collector, len(c.mssqlInstances))
errs := make([]error, 0, len(c.mssqlInstances)) errs := make([]error, 0, len(c.mssqlInstances))
counters := []string{ counters := []string{
sqlStatsAutoParamAttemptsPerSec, sqlStatsAutoParamAttemptsPerSec,
@@ -74,7 +74,7 @@ func (c *Collector) buildSQLStats() error {
} }
for sqlInstance := range c.mssqlInstances { for sqlInstance := range c.mssqlInstances {
c.genStatsPerfDataCollectors[sqlInstance], err = perfdata.NewCollector(c.mssqlGetPerfObjectName(sqlInstance, "SQL Statistics"), nil, counters) c.sqlStatsPerfDataCollectors[sqlInstance], err = perfdata.NewCollector(c.mssqlGetPerfObjectName(sqlInstance, "SQL Statistics"), nil, counters)
if err != nil { if err != nil {
errs = append(errs, fmt.Errorf("failed to create SQL Statistics collector for instance %s: %w", sqlInstance, err)) errs = append(errs, fmt.Errorf("failed to create SQL Statistics collector for instance %s: %w", sqlInstance, err))
} }