sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-10-17 10:09:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

storage_spaces: add primordial label to pool info (#2650)

Browse Source 
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This commit is contained in:
Jan-Otto Kröpke
2026-10-10 17:08:05 +02:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 3e013fe22b
commit ec82f90a79
3 changed files with 49 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/collector/storage_spaces/storage_spaces_pool.go
+5 -3
View File
@@ -44,6 +44,7 @@ type collectorStoragePool struct {
type msftStoragePool struct {
FriendlyName string `mi:"FriendlyName"`
UniqueId string `mi:"UniqueId"`
IsPrimordial bool `mi:"IsPrimordial"`
HealthStatus uint16 `mi:"HealthStatus"`
Size uint64 `mi:"Size"`
AllocatedSize uint64 `mi:"AllocatedSize"`
@@ -53,7 +54,7 @@ type msftStoragePool struct {
}
func (c *Collector) buildStoragePool() error {
wmiSelect := "FriendlyName,UniqueId,HealthStatus,Size,AllocatedSize,OperationalStatus,ThinProvisioningAlertThresholds"
wmiSelect := "FriendlyName,UniqueId,IsPrimordial,HealthStatus,Size,AllocatedSize,OperationalStatus,ThinProvisioningAlertThresholds"
storagePoolMIQuery, err := mi.NewQuery(fmt.Sprintf("SELECT %s FROM MSFT_StoragePool", wmiSelect))
if err != nil {
@@ -64,8 +65,8 @@ func (c *Collector) buildStoragePool() error {
c.storagePoolInfo = prometheus.NewDesc(
prometheus.BuildFQName(types.Namespace, nameStoragePool, "info"),
"Storage pool information (value is always 1)",
[]string{"name", "unique_id"},
"Storage pool information (value is always 1). primordial is true for the built-in primordial pool",
[]string{"name", "unique_id", "primordial"},
nil,
)
@@ -127,6 +128,7 @@ func (c *Collector) collectStoragePool(ch chan<- prometheus.Metric, maxScrapeDur
1.0,
pool.FriendlyName,
pool.UniqueId,
strconv.FormatBool(pool.IsPrimordial),
)
ch <- prometheus.MustNewConstMetric(
internal/collector/storage_spaces/storage_spaces_test.go
+15 -1
View File
@@ -36,7 +36,7 @@ func TestCollector(t *testing.T) {
pool := prometheus.Labels{"name": "GitHubActions"}
virtualDisk := prometheus.Labels{"name": "CIVirtualDisk"}
testutils.RequireFixtureMetric(t, metrics, storage_spaces.Name, "windows_storage_spaces_pool_info", pool)
testutils.RequireFixtureMetric(t, metrics, storage_spaces.Name, "windows_storage_spaces_pool_info", prometheus.Labels{"name": "GitHubActions", "primordial": "false"})
testutils.RequireFixtureMetric(t, metrics, storage_spaces.Name, "windows_storage_spaces_virtual_disk_info", virtualDisk)
for _, tc := range []struct {
@@ -66,4 +66,18 @@ func TestCollector(t *testing.T) {
require.Greater(t, value, 0.0)
require.LessOrEqual(t, value, 100.0)
}
// Every pool, including the built-in primordial pool, must carry a boolean primordial label.
for _, metric := range metrics["windows_storage_spaces_pool_info"].GetMetric() {
var primordial []string
for _, label := range metric.GetLabel() {
if label.GetName() == "primordial" {
primordial = append(primordial, label.GetValue())
}
}
require.Len(t, primordial, 1, "pool info metric %s", metric)
require.Contains(t, []string{"true", "false"}, primordial[0], "pool info metric %s", metric)
}
}