chore: Remove registry based perfdata collector (#1742)

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This commit is contained in:
Jan-Otto Kröpke
2024-11-17 21:51:12 +01:00
committed by GitHub
parent 6206b695c6
commit e6a15d4ec4
213 changed files with 8079 additions and 12405 deletions

View File

@@ -1,3 +1,5 @@
//go:build windows
package remote_fx
const (

View File

@@ -30,8 +30,8 @@ var ConfigDefaults = Config{}
type Collector struct {
config Config
perfDataCollectorNetwork perfdata.Collector
perfDataCollectorGraphics perfdata.Collector
perfDataCollectorNetwork *perfdata.Collector
perfDataCollectorGraphics *perfdata.Collector
// net
baseTCPRTT *prometheus.Desc
@@ -78,11 +78,7 @@ func (c *Collector) GetName() string {
return Name
}
func (c *Collector) GetPerfCounter(_ *slog.Logger) ([]string, error) {
return []string{}, nil
}
func (c *Collector) Close(_ *slog.Logger) error {
func (c *Collector) Close() error {
c.perfDataCollectorNetwork.Close()
c.perfDataCollectorGraphics.Close()
@@ -92,7 +88,7 @@ func (c *Collector) Close(_ *slog.Logger) error {
func (c *Collector) Build(*slog.Logger, *mi.Session) error {
var err error
c.perfDataCollectorNetwork, err = perfdata.NewCollector(perfdata.V2, "RemoteFX Network", perfdata.AllInstances, []string{
c.perfDataCollectorNetwork, err = perfdata.NewCollector("RemoteFX Network", perfdata.InstanceAll, []string{
BaseTCPRTT,
BaseUDPRTT,
CurrentTCPBandwidth,
@@ -111,7 +107,7 @@ func (c *Collector) Build(*slog.Logger, *mi.Session) error {
return fmt.Errorf("failed to create RemoteFX Network collector: %w", err)
}
c.perfDataCollectorGraphics, err = perfdata.NewCollector(perfdata.V2, "RemoteFX Graphics", perfdata.AllInstances, []string{
c.perfDataCollectorGraphics, err = perfdata.NewCollector("RemoteFX Graphics", perfdata.InstanceAll, []string{
AverageEncodingTime,
FrameQuality,
FramesSkippedPerSecondInsufficientClientResources,
@@ -255,7 +251,7 @@ func (c *Collector) Build(*slog.Logger, *mi.Session) error {
// Collect sends the metric values for each metric
// to the provided prometheus Metric channel.
func (c *Collector) Collect(_ *types.ScrapeContext, _ *slog.Logger, ch chan<- prometheus.Metric) error {
func (c *Collector) Collect(ch chan<- prometheus.Metric) error {
errs := make([]error, 0, 2)
if err := c.collectRemoteFXNetworkCount(ch); err != nil {

View File

@@ -1,10 +1,12 @@
//go:build windows
package remote_fx_test
import (
"testing"
"github.com/prometheus-community/windows_exporter/internal/collector/remote_fx"
"github.com/prometheus-community/windows_exporter/internal/testutils"
"github.com/prometheus-community/windows_exporter/internal/utils/testutils"
)
func BenchmarkCollector(b *testing.B) {