sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-10-20 11:39:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

pdh: convert all raw time counter types to seconds (#2776)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
This commit is contained in:
Jan-Otto Kröpke
2026-10-16 22:54:44 +02:00
committed by GitHub
co-authored by Claude
parent a9d5bbef48
commit da7bebc6b3
23 changed files with 313 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AGENTS.md
+5 -4
View File
@@ -141,10 +141,11 @@ exercised a live Windows role.
appropriate. Raw PDH values can be cumulative numerators, ticks or counts,
even when the Windows counter name says average, percentage or seconds.
Convert units explicitly; expose the base/operation count needed for ratios.
The raw value of a `PERF_AVERAGE_TIMER` counter is in ticks of its time
base: in new code, divide it by `pdh.Collector.Frequency` instead of a fixed
factor. The disk and `smbclient` collectors still use the fixed 1e-7
(10 MHz) factor.
With `pdh.CounterTypeRaw`, `internal/pdh` converts the time types to seconds:
the 100 ns timers and `PERF_COUNTER_100NS_QUEUELEN_TYPE` by dividing by
`pdh.TicksPerSecond`, and `PERF_AVERAGE_TIMER` by dividing by the counter's
own time base (its `,secondvalue` stays the operation count). Don't scale
these again in a collector.
Never publish an invalid sample as zero: that can look like a counter reset.
- Keep the typed PDH collectors and `perfdata` tags. `internal/pdh` passes
instance names through unchanged, so a `#N` in a name always comes from