sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-02-17 10:16:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

reorder functions

Browse Source 
so that the two functions that list available child collectors are next
to each other - should make less likely to not miss editing one of those
when adding additional wmi classes

also removed the 'filter' from the `mssqlFilterAvailableClassCollectors`
function as it's not filtering anyting.
This commit is contained in:
Steve Zook
2018-08-03 09:48:32 -04:00
parent fe4c61a70e
commit d83615a818
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
collector/mssql.go
View File

@@ -37,7 +37,7 @@ var (
mssqlEnabledCollectors = kingpin.Flag( mssqlEnabledCollectors = kingpin.Flag(
"collectors.mssql.classes-enabled", "collectors.mssql.classes-enabled",
"Comma-separated list of mssql WMI classes to use."). "Comma-separated list of mssql WMI classes to use.").
Default(mssqlFilterAvailableClassCollectors()).String() Default(mssqlAvailableClassCollectors()).String()
mssqlPrintCollectors = kingpin.Flag( mssqlPrintCollectors = kingpin.Flag(
"collectors.mssql.class-print", "collectors.mssql.class-print",
@@ -80,10 +80,24 @@ func getMSSQLInstances() mssqlInstancesType {
type mssqlCollectorsMap map[string]mssqlCollectorFunc type mssqlCollectorsMap map[string]mssqlCollectorFunc
func mssqlFilterAvailableClassCollectors() string { func mssqlAvailableClassCollectors() string {
return "availreplica,bufman,databases,dbreplica,genstats,locks,memmgr,sqlstats" return "availreplica,bufman,databases,dbreplica,genstats,locks,memmgr,sqlstats"
} }
func (c *MSSQLCollector) getMSSQLCollectors() mssqlCollectorsMap {
mssqlCollectors := make(mssqlCollectorsMap)
mssqlCollectors["availreplica"] = c.collectAvailabilityReplica
mssqlCollectors["bufman"] = c.collectBufferManager
mssqlCollectors["databases"] = c.collectDatabases
mssqlCollectors["dbreplica"] = c.collectDatabaseReplica
mssqlCollectors["genstats"] = c.collectGeneralStatistics
mssqlCollectors["locks"] = c.collectLocks
mssqlCollectors["memmgr"] = c.collectMemoryManager
mssqlCollectors["sqlstats"] = c.collectSQLStats
return mssqlCollectors
}
func mssqlExpandEnabledCollectors(enabled string) []string { func mssqlExpandEnabledCollectors(enabled string) []string {
separated := strings.Split(enabled, ",") separated := strings.Split(enabled, ",")
unique := map[string]bool{} unique := map[string]bool{}
@@ -99,20 +113,6 @@ func mssqlExpandEnabledCollectors(enabled string) []string {
return result return result
} }
func (c *MSSQLCollector) getMSSQLCollectors() mssqlCollectorsMap {
mssqlCollectors := make(mssqlCollectorsMap)
mssqlCollectors["availreplica"] = c.collectAvailabilityReplica
mssqlCollectors["bufman"] = c.collectBufferManager
mssqlCollectors["databases"] = c.collectDatabases
mssqlCollectors["dbreplica"] = c.collectDatabaseReplica
mssqlCollectors["genstats"] = c.collectGeneralStatistics
mssqlCollectors["locks"] = c.collectLocks
mssqlCollectors["memmgr"] = c.collectMemoryManager
mssqlCollectors["sqlstats"] = c.collectSQLStats
return mssqlCollectors
}
func init() { func init() {
Factories["mssql"] = NewMSSQLCollector Factories["mssql"] = NewMSSQLCollector
} }