From bf722630d60b48d6265d0e2e35a9c91bbbc3e922 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan-Otto=20Kr=C3=B6pke?= Date: Sat, 5 Jul 2025 00:20:28 +0200 Subject: [PATCH] mssql: fix ratio based counter (#2096) --- internal/collector/mssql/mssql_access_methods.go | 2 +- internal/collector/mssql/mssql_buffer_manager.go | 2 +- internal/collector/mssql/mssql_database.go | 2 +- internal/collector/mssql/mssql_locks.go | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/collector/mssql/mssql_access_methods.go b/internal/collector/mssql/mssql_access_methods.go index ee987cd3..d937165c 100644 --- a/internal/collector/mssql/mssql_access_methods.go +++ b/internal/collector/mssql/mssql_access_methods.go @@ -120,7 +120,7 @@ type perfDataCounterValuesAccessMethods struct { AccessMethodsWorkfilesCreatedPerSec float64 `perfdata:"Workfiles Created/sec"` AccessMethodsWorktablesCreatedPerSec float64 `perfdata:"Worktables Created/sec"` AccessMethodsWorktablesFromCacheRatio float64 `perfdata:"Worktables From Cache Ratio"` - AccessMethodsWorktablesFromCacheRatioBase float64 `perfdata:"Worktables From Cache Base,secondvalue"` + AccessMethodsWorktablesFromCacheRatioBase float64 `perfdata:"Worktables From Cache Ratio,secondvalue"` } func (c *Collector) buildAccessMethods() error { diff --git a/internal/collector/mssql/mssql_buffer_manager.go b/internal/collector/mssql/mssql_buffer_manager.go index 93b75150..f0307a6e 100644 --- a/internal/collector/mssql/mssql_buffer_manager.go +++ b/internal/collector/mssql/mssql_buffer_manager.go @@ -58,7 +58,7 @@ type collectorBufferManager struct { type perfDataCounterValuesBufMan struct { BufManBackgroundWriterPagesPerSec float64 `perfdata:"Background writer pages/sec"` BufManBufferCacheHitRatio float64 `perfdata:"Buffer cache hit ratio"` - BufManBufferCacheHitRatioBase float64 `perfdata:"Buffer cache hit ratio base,secondvalue"` + BufManBufferCacheHitRatioBase float64 `perfdata:"Buffer cache hit ratio,secondvalue"` BufManCheckpointPagesPerSec float64 `perfdata:"Checkpoint pages/sec"` BufManDatabasePages float64 `perfdata:"Database pages"` BufManExtensionAllocatedPages float64 `perfdata:"Extension allocated pages"` diff --git a/internal/collector/mssql/mssql_database.go b/internal/collector/mssql/mssql_database.go index f1fcc4d9..e068c132 100644 --- a/internal/collector/mssql/mssql_database.go +++ b/internal/collector/mssql/mssql_database.go @@ -95,7 +95,7 @@ type perfDataCounterValuesDatabases struct { DatabasesGroupCommitTimePerSec float64 `perfdata:"Group Commit Time/sec"` DatabasesLogBytesFlushedPerSec float64 `perfdata:"Log Bytes Flushed/sec"` DatabasesLogCacheHitRatio float64 `perfdata:"Log Cache Hit Ratio"` - DatabasesLogCacheHitRatioBase float64 `perfdata:"Log Cache Hit Ratio Base,secondvalue"` + DatabasesLogCacheHitRatioBase float64 `perfdata:"Log Cache Hit Ratio,secondvalue"` DatabasesLogCacheReadsPerSec float64 `perfdata:"Log Cache Reads/sec"` DatabasesLogFilesSizeKB float64 `perfdata:"Log File(s) Size (KB)"` DatabasesLogFilesUsedSizeKB float64 `perfdata:"Log File(s) Used Size (KB)"` diff --git a/internal/collector/mssql/mssql_locks.go b/internal/collector/mssql/mssql_locks.go index 6663f3da..9cde27e3 100644 --- a/internal/collector/mssql/mssql_locks.go +++ b/internal/collector/mssql/mssql_locks.go @@ -45,7 +45,7 @@ type perfDataCounterValuesLocks struct { Name string LocksAverageWaitTimeMS float64 `perfdata:"Average Wait Time (ms)"` - LocksAverageWaitTimeMSBase float64 `perfdata:"Average Wait Time Base,secondvalue"` + LocksAverageWaitTimeMSBase float64 `perfdata:"Average Wait Time (ms),secondvalue"` LocksLockRequestsPerSec float64 `perfdata:"Lock Requests/sec"` LocksLockTimeoutsPerSec float64 `perfdata:"Lock Timeouts/sec"` LocksLockTimeoutsTimeout0PerSec float64 `perfdata:"Lock Timeouts (timeout > 0)/sec"`