sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-03-05 01:56:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge mssql and dfsr expandEnabledCollectors func

Browse Source 
Move to common collector.go and add function test.

Signed-off-by: Ben Reedy <breed808@breed808.com>
This commit is contained in:
Ben Reedy
2020-12-03 20:20:28 +10:00
parent ccac306c2d
commit b5ce53fdac
4 changed files with 57 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
collector/dfsr.go
View File

@@ -4,7 +4,6 @@ package collector
import (
"errors"
"strings"
"sync"
"time"
@@ -88,22 +87,6 @@ type dfsrCollectorMap map[string]dfsrCollectorFunc
type dfsrCollectorFunc func(ctx *ScrapeContext, ch chan<- prometheus.Metric) (*prometheus.Desc, error)
// Split provided perflib sources and deduplicate
func dfsrExpandEnabledSources(enabled string) []string {
separated := strings.Split(enabled, ",")
unique := map[string]bool{}
for _, s := range separated {
if s != "" {
unique[s] = true
}
}
result := make([]string, 0, len(unique))
for s := range unique {
result = append(result, s)
}
return result
}
// Map Perflib sources to DFSR collector names
// E.G. volume -> DFS Replication Service Volumes
func dfsrGetPerfObjectName(collector string) string {
@@ -124,7 +107,7 @@ func dfsrGetPerfObjectName(collector string) string {
func NewDFSRCollector() (Collector, error) {
const subsystem = "dfsr"
enabled := dfsrExpandEnabledSources(*dfsrEnabledCollectors)
enabled := expandEnabledChildCollectors(*dfsrEnabledCollectors)
perfCounters := make([]string, 0, len(enabled))
for _, c := range enabled {
perfCounters = append(perfCounters, dfsrGetPerfObjectName(c))