sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-03-04 17:46:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

mssql: set windows_exporter_collector_success to 0, if errors occurs (#1777)

Browse Source 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This commit is contained in:
Jan-Otto Kröpke
2024-11-27 00:14:53 +01:00
committed by GitHub
parent 64bf0a6551
commit a2db81494e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/collector/mssql/mssql.go
View File

@@ -257,13 +257,15 @@ func (c *Collector) Build(logger *slog.Logger, _ *mi.Session) error {
// Result must order, to prevent test failures. // Result must order, to prevent test failures.
sort.Strings(c.config.CollectorsEnabled) sort.Strings(c.config.CollectorsEnabled)
errs := make([]error, 0, len(c.config.CollectorsEnabled))
for _, name := range c.config.CollectorsEnabled { for _, name := range c.config.CollectorsEnabled {
if _, ok := subCollectors[name]; !ok { if _, ok := subCollectors[name]; !ok {
return fmt.Errorf("unknown collector: %s", name) return fmt.Errorf("unknown collector: %s", name)
} }
if err := subCollectors[name].build(); err != nil { if err := subCollectors[name].build(); err != nil {
return fmt.Errorf("failed to build %s collector: %w", name, err) errs = append(errs, fmt.Errorf("failed to build %s collector: %w", name, err))
} }
c.collectorFns = append(c.collectorFns, subCollectors[name].collect) c.collectorFns = append(c.collectorFns, subCollectors[name].collect)
@@ -291,7 +293,7 @@ func (c *Collector) Build(logger *slog.Logger, _ *mi.Session) error {
nil, nil,
) )
return nil return errors.Join(errs...)
} }
// Collect sends the metric values for each metric // Collect sends the metric values for each metric
@@ -408,7 +410,7 @@ func (c *Collector) collect(
errs = append(errs, err) errs = append(errs, err)
success = 0.0 success = 0.0
c.logger.Error(fmt.Sprintf("mssql class collector %s for instance %s failed after %s", collector, sqlInstance, duration), c.logger.Debug(fmt.Sprintf("mssql class collector %s for instance %s failed after %s", collector, sqlInstance, duration),
slog.Any("err", err), slog.Any("err", err),
) )
} else { } else {