From a1a986f4d0fe9dab352f84e42f853cc584c6e0a7 Mon Sep 17 00:00:00 2001 From: Ben Reedy Date: Wed, 9 Dec 2020 14:47:53 +1000 Subject: [PATCH] Reset mssql child failure counter on each scrape Resolves issue where collector would always return a failure after an inital failure, as the counter was not reset. Signed-off-by: Ben Reedy --- collector/mssql.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/collector/mssql.go b/collector/mssql.go index 4f746146..17bf8c4e 100644 --- a/collector/mssql.go +++ b/collector/mssql.go @@ -1808,6 +1808,8 @@ func NewMSSQLCollector() (Collector, error) { type mssqlCollectorFunc func(ctx *ScrapeContext, ch chan<- prometheus.Metric, sqlInstance string) (*prometheus.Desc, error) func (c *MSSQLCollector) execute(ctx *ScrapeContext, name string, fn mssqlCollectorFunc, ch chan<- prometheus.Metric, sqlInstance string, wg *sync.WaitGroup) { + // Reset failure counter on each scrape + c.mssqlChildCollectorFailure = 0 defer wg.Done() begin := time.Now()