sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-03-11 13:06:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Lint-fix: errcheck. Partial fix to #261

Browse Source
This commit is contained in:
Calle Pettersson
2018-10-05 07:29:56 +02:00
committed by Calle Pettersson
parent e24e0dc9f5
commit a171401f57
5 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
collector/iis.go
View File

@@ -30,7 +30,12 @@ func getIISVersion() simple_version {
log.Warn("Couldn't open registry to determine IIS version:", err) log.Warn("Couldn't open registry to determine IIS version:", err)
return simple_version{} return simple_version{}
} }
defer k.Close() defer func() {
err = k.Close()
if err != nil {
log.Warnf("Failed to close registry key: %v", err)
}
}()
major, _, err := k.GetIntegerValue("MajorVersion") major, _, err := k.GetIntegerValue("MajorVersion")
if err != nil { if err != nil {

7
collector/mssql.go
View File

@@ -44,7 +44,12 @@ func getMSSQLInstances() mssqlInstancesType {
log.Warn("Couldn't open registry to determine SQL instances:", err) log.Warn("Couldn't open registry to determine SQL instances:", err)
return sqlDefaultInstance return sqlDefaultInstance
} }
defer k.Close() defer func() {
err = k.Close()
if err != nil {
log.Warnf("Failed to close registry key: %v", err)
}
}()
instanceNames, err := k.ReadValueNames(0) instanceNames, err := k.ReadValueNames(0)
if err != nil { if err != nil {

2
collector/process.go
View File

@@ -194,7 +194,7 @@ func (c *ProcessCollector) collect(ch chan<- prometheus.Metric) (*prometheus.Des
var dst_wp []WorkerProcess var dst_wp []WorkerProcess
q_wp := queryAll(&dst_wp) q_wp := queryAll(&dst_wp)
if err := wmi.QueryNamespace(q_wp, &dst_wp, "root\\WebAdministration"); err != nil { if err := wmi.QueryNamespace(q_wp, &dst_wp, "root\\WebAdministration"); err != nil {
log.Warnf("failed querying worker processes: %s", err) log.Debugf("Could not query WebAdministration namespace for IIS worker processes: %v. Skipping", err)
} }
for _, process := range dst { for _, process := range dst {

5
collector/textfile.go
View File

@@ -244,7 +244,10 @@ fileLoop:
continue continue
} }
parsedFamilies, err := parser.TextToMetricFamilies(r) parsedFamilies, err := parser.TextToMetricFamilies(r)
file.Close() closeErr := file.Close()
if closeErr != nil {
log.Warnf("Error closing file: %v", err)
}
if err != nil { if err != nil {
log.Errorf("Error parsing %q: %v", path, err) log.Errorf("Error parsing %q: %v", path, err)
error = 1.0 error = 1.0

10
exporter.go
View File

@@ -4,7 +4,6 @@ package main
import ( import (
"fmt" "fmt"
"io"
"net/http" "net/http"
"sort" "sort"
"strings" "strings"
@@ -222,7 +221,12 @@ func main() {
stopCh := make(chan bool) stopCh := make(chan bool)
if !isInteractive { if !isInteractive {
go svc.Run(serviceName, &wmiExporterService{stopCh: stopCh}) go func() {
err = svc.Run(serviceName, &wmiExporterService{stopCh: stopCh})
if err != nil {
log.Errorf("Failed to start service: %v", err)
}
}()
} }
collectors, err := loadCollectors(*enabledCollectors) collectors, err := loadCollectors(*enabledCollectors)
@@ -259,7 +263,7 @@ func main() {
func healthCheck(w http.ResponseWriter, r *http.Request) { func healthCheck(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
io.WriteString(w, `{"status":"ok"}`) fmt.Fprintln(w, `{"status":"ok"}`)
} }
func keys(m map[string]collector.Collector) []string { func keys(m map[string]collector.Collector) []string {