terminal_services: fix panic in collect (#1906)

This commit is contained in:
Jan-Otto Kröpke
2025-02-28 07:53:23 +01:00
committed by GitHub
parent d645e89be9
commit a0e132b30e

View File

@@ -139,13 +139,6 @@ func (c *Collector) Build(logger *slog.Logger, miSession *mi.Session) error {
c.logger = logger.With(slog.String("collector", Name)) c.logger = logger.With(slog.String("collector", Name))
var err error
c.perfDataCollectorTerminalServicesSession, err = pdh.NewCollector[perfDataCounterValuesTerminalServicesSession](pdh.CounterTypeRaw, "Terminal Services Session", pdh.InstancesAll)
if err != nil {
return fmt.Errorf("failed to create Terminal Services Session collector: %w", err)
}
c.connectionBrokerEnabled = isConnectionBrokerServer(miSession) c.connectionBrokerEnabled = isConnectionBrokerServer(miSession)
if c.connectionBrokerEnabled { if c.connectionBrokerEnabled {
@@ -250,11 +243,18 @@ func (c *Collector) Build(logger *slog.Logger, miSession *mi.Session) error {
nil, nil,
) )
var err error
c.hServer, err = wtsapi32.WTSOpenServer("") c.hServer, err = wtsapi32.WTSOpenServer("")
if err != nil { if err != nil {
return fmt.Errorf("failed to open WTS server: %w", err) return fmt.Errorf("failed to open WTS server: %w", err)
} }
c.perfDataCollectorTerminalServicesSession, err = pdh.NewCollector[perfDataCounterValuesTerminalServicesSession](pdh.CounterTypeRaw, "Terminal Services Session", pdh.InstancesAll)
if err != nil {
return fmt.Errorf("failed to create Terminal Services Session collector: %w", err)
}
return nil return nil
} }