sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-03-04 01:26:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1080 from breed808/scheduled_task_memory

Browse Source 
fix: Remove memory leaks in scheduled_task
This commit is contained in:
Ben Reedy
2022-10-25 08:51:32 +10:00
committed by GitHub
parent 70dcd80f3d 25d23852d4
commit 9a262579ce
1 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
collector/scheduled_task.go
View File

@@ -220,6 +220,7 @@ func fetchTasksInFolder(folder *ole.IDispatch, scheduledTasks *ScheduledTasks) e
err = oleutil.ForEach(tasks, func(v *ole.VARIANT) error { err = oleutil.ForEach(tasks, func(v *ole.VARIANT) error {
task := v.ToIDispatch() task := v.ToIDispatch()
defer task.Release()
parsedTask, err := parseTask(task) parsedTask, err := parseTask(task)
if err != nil { if err != nil {
@@ -249,6 +250,7 @@ func fetchTasksRecursively(folder *ole.IDispatch, scheduledTasks *ScheduledTasks
err = oleutil.ForEach(subFolders, func(v *ole.VARIANT) error { err = oleutil.ForEach(subFolders, func(v *ole.VARIANT) error {
subFolder := v.ToIDispatch() subFolder := v.ToIDispatch()
defer subFolder.Release()
return fetchTasksRecursively(subFolder, scheduledTasks) return fetchTasksRecursively(subFolder, scheduledTasks)
}) })
@@ -260,31 +262,61 @@ func parseTask(task *ole.IDispatch) (scheduledTask ScheduledTask, err error) {
if err != nil { if err != nil {
return scheduledTask, err return scheduledTask, err
} }
defer func() {
if tempErr := taskNameVar.Clear(); tempErr != nil {
err = tempErr
}
}()
taskPathVar, err := oleutil.GetProperty(task, "Path") taskPathVar, err := oleutil.GetProperty(task, "Path")
if err != nil { if err != nil {
return scheduledTask, err return scheduledTask, err
} }
defer func() {
if tempErr := taskPathVar.Clear(); tempErr != nil {
err = tempErr
}
}()
taskEnabledVar, err := oleutil.GetProperty(task, "Enabled") taskEnabledVar, err := oleutil.GetProperty(task, "Enabled")
if err != nil { if err != nil {
return scheduledTask, err return scheduledTask, err
} }
defer func() {
if tempErr := taskEnabledVar.Clear(); tempErr != nil {
err = tempErr
}
}()
taskStateVar, err := oleutil.GetProperty(task, "State") taskStateVar, err := oleutil.GetProperty(task, "State")
if err != nil { if err != nil {
return scheduledTask, err return scheduledTask, err
} }
defer func() {
if tempErr := taskStateVar.Clear(); tempErr != nil {
err = tempErr
}
}()
taskNumberOfMissedRunsVar, err := oleutil.GetProperty(task, "NumberOfMissedRuns") taskNumberOfMissedRunsVar, err := oleutil.GetProperty(task, "NumberOfMissedRuns")
if err != nil { if err != nil {
return scheduledTask, err return scheduledTask, err
} }
defer func() {
if tempErr := taskNumberOfMissedRunsVar.Clear(); tempErr != nil {
err = tempErr
}
}()
taskLastTaskResultVar, err := oleutil.GetProperty(task, "LastTaskResult") taskLastTaskResultVar, err := oleutil.GetProperty(task, "LastTaskResult")
if err != nil { if err != nil {
return scheduledTask, err return scheduledTask, err
} }
defer func() {
if tempErr := taskLastTaskResultVar.Clear(); tempErr != nil {
err = tempErr
}
}()
scheduledTask.Name = taskNameVar.ToString() scheduledTask.Name = taskNameVar.ToString()
scheduledTask.Path = strings.ReplaceAll(taskPathVar.ToString(), "\\", "/") scheduledTask.Path = strings.ReplaceAll(taskPathVar.ToString(), "\\", "/")