sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-10-17 10:09:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

mi: validate unmarshal target before querying and unit-test setField (#2520)

Browse Source 
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This commit is contained in:
Jan-Otto Kröpke
2026-10-07 18:15:45 +02:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 7d5342749a
commit 94dc2c0284
5 changed files with 230 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/utils/testutils/testutils.go
+1 -10
View File
@@ -116,16 +116,7 @@ func TestCollector[C collector.Collector, V any](t *testing.T, fn func(*V) C, co
// is only accepted here (Build path) so that a mistyped class in production
// code still fails Collect.
func unsupportedBuild(err error) bool {
return errors.Is(err, mi.MI_RESULT_INVALID_CLASS) ||
errors.Is(err, mi.MI_RESULT_INVALID_NAMESPACE) ||
errors.Is(err, mi.MI_RESULT_INVALID_QUERY) ||
errors.Is(err, pdh.NewPdhError(pdh.CstatusNoCounter)) ||
errors.Is(err, pdh.NewPdhError(pdh.CstatusNoObject)) ||
errors.Is(err, pdh.ErrPerformanceCounterNotInitialized) ||
errors.Is(err, pdh.ErrNoData) ||
errors.Is(err, update.ErrUpdateServiceDisabled) ||
errors.Is(err, os.ErrNotExist) ||
errors.Is(err, windows.Errno(2151088411))
return errors.Is(err, mi.MI_RESULT_INVALID_CLASS) || unsupportedCollect(err)
}
// unsupportedCollect returns true for Collect-path errors that indicate a