From 791df8009ca60e0ef7454f2595c0891cc347d317 Mon Sep 17 00:00:00 2001 From: Ben Reedy Date: Wed, 6 Apr 2022 21:10:03 +1000 Subject: [PATCH 1/2] Update golangci-lint CI action to latest version Signed-off-by: Ben Reedy --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 895e4258..23813402 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -85,9 +85,9 @@ jobs: go-version: '^1.17.5' - name: golangci-lint - uses: golangci/golangci-lint-action@v2 + uses: golangci/golangci-lint-action@v3 with: - version: v1.43 + version: v1.45.2 args: "--timeout=5m" # golangci-lint action doesn't always provide helpful output, so re-run without the action for From 02e2e257c9d2cef6abab8de7d42686688834375c Mon Sep 17 00:00:00 2001 From: Ben Reedy Date: Thu, 7 Apr 2022 08:23:28 +1000 Subject: [PATCH 2/2] Use `go install` for build deps Previous `go get` method of installation was causing issues with `goversiontool`, preventing successful CI builds. Signed-off-by: Ben Reedy --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 23813402..ab92f3de 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -128,8 +128,8 @@ jobs: - name: Install Build deps run: | dotnet tool install --global GitVersion.Tool --version 5.* - go get "github.com/prometheus/promu@$($Env:PROMU_VER)" - go get github.com/josephspurrier/goversioninfo/cmd/goversioninfo@v1.2.0 + go install "github.com/prometheus/promu@$($Env:PROMU_VER)" + go install github.com/josephspurrier/goversioninfo/cmd/goversioninfo@v1.4.0 # GOPATH\bin dir must be added to PATH else the `promu` and `goversioninfo` commands won't be found echo "$(go env GOPATH)\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append