chore: pass context aware logger to collectors (#1582)

This commit is contained in:
Jan-Otto Kröpke
2024-08-24 19:14:38 +02:00
committed by GitHub
parent fbead0fb79
commit 89c832feb0
65 changed files with 876 additions and 1164 deletions

View File

@@ -15,10 +15,11 @@ import (
func FuncBenchmarkCollector[C collector.Collector](b *testing.B, name string, collectFunc collector.BuilderWithFlags[C]) {
b.Helper()
logger := log.NewNopLogger()
c := collectFunc(kingpin.CommandLine)
collectors := collector.New(map[string]collector.Collector{name: c})
require.NoError(b, collectors.Build())
collectors.SetLogger(log.NewNopLogger())
require.NoError(b, collectors.Build(logger))
// Create perflib scrape context.
// Some perflib collectors required a correct context,
@@ -34,6 +35,6 @@ func FuncBenchmarkCollector[C collector.Collector](b *testing.B, name string, co
}()
for i := 0; i < b.N; i++ {
require.NoError(b, c.Collect(scrapeContext, metrics))
require.NoError(b, c.Collect(scrapeContext, logger, metrics))
}
}