From 7876a465cabc2c0a68dbe4d91dd000d292966f90 Mon Sep 17 00:00:00 2001 From: Dinifarb Date: Sat, 29 Jul 2023 20:53:38 +0200 Subject: [PATCH] fix: linter issue Signed-off-by: Dinifarb --- collector/textfile.go | 5 ++--- collector/textfile_test.go | 10 ++++++++-- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/collector/textfile.go b/collector/textfile.go index 2d60f713..0fa82e10 100644 --- a/collector/textfile.go +++ b/collector/textfile.go @@ -294,10 +294,9 @@ func (c *textFileCollector) Collect(ctx *ScrapeContext, ch chan<- prometheus.Met _ = level.Error(c.logger).Log("msg", fmt.Sprintf("Duplicate filename detected: %q. Skip File.", path)) errorMetric = 1.0 return nil - } else { - mtimes[fileInfo.Name()] = fileInfo.ModTime() - metricFamilies = append(metricFamilies, families_array...) } + mtimes[fileInfo.Name()] = fileInfo.ModTime() + metricFamilies = append(metricFamilies, families_array...) } return nil }) diff --git a/collector/textfile_test.go b/collector/textfile_test.go index 91ab4642..a398a4da 100644 --- a/collector/textfile_test.go +++ b/collector/textfile_test.go @@ -177,7 +177,10 @@ func TestMultipleDirectories(t *testing.T) { for { var metric dto.Metric val := <-metrics - val.Write(&metric) + err := val.Write(&metric) + if err != nil { + t.Errorf("Unexpected error %s", err) + } got += metric.String() } }() @@ -208,7 +211,10 @@ func TestDuplicateFileName(t *testing.T) { for { var metric dto.Metric val := <-metrics - val.Write(&metric) + err := val.Write(&metric) + if err != nil { + t.Errorf("Unexpected error %s", err) + } got += metric.String() } }()