chore(deps): update dependency golangci/golangci-lint to v2.13.1 (master) (#2477)

Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>

.github/workflows/lint.yml

@@ -94,5 +94,5 @@ jobs:
         uses: golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a # v9.3.0
         with:
           # renovate: github=golangci/golangci-lint
-          version: v2.12.2
+          version: v2.13.1
           args: "--max-same-issues=0"

.golangci.yaml

@@ -1,3 +1,4 @@
+# $schema: https://golangci-lint.run/jsonschema/golangci.jsonschema.json
 version: "2"
 linters:
   default: all
@@ -9,6 +10,7 @@ linters:
     - err113
     - exhaustive
     - exhaustruct
+    - exhaustruct_v5
     - fatcontext
     - funcorder
     - funlen

cmd/windows_exporter/main_test.go

@@ -190,8 +190,7 @@ func waitUntilListening(tb testing.TB, network, address string) error {
 		break
 	}
 
-	var winErr windows.Errno
+	if winErr, ok := errors.AsType[windows.Errno](err); ok {
-	if errors.As(err, &winErr) {
 		return fmt.Errorf("listener not listening: %w (#%d)", winErr, uint32(winErr))
 	}
 

internal/collector/iis/iis.go

@@ -304,7 +304,7 @@ func deduplicateIISNames[T collectorName](counterValues []T) {
 
 	// Use map to deduplicate IIS entries
 	for index, counterValue := range counterValues {
-		name := strings.Split(counterValue.GetName(), "#")[0]
+		name, _, _ := strings.Cut(counterValue.GetName(), "#")
 		if name == counterValue.GetName() {
 			continue
 		}

internal/collector/performancecounter/performancecounter.go

@@ -328,7 +328,7 @@ func (c *Collector) collectObject(ch chan<- prometheus.Metric, perfDataObject Ob
 				continue
 			}
 
-			metricType, _ := field.Interface().(prometheus.ValueType)
+			metricType, _ := reflect.TypeAssert[prometheus.ValueType](field)
 
 			labels := make(prometheus.Labels, len(counter.Labels)+1)
 

internal/collector/printer/printer.go

@@ -265,7 +265,7 @@ func (c *Collector) groupPrintJobs(printJobs []wmiPrintJob) map[PrintJobStatusGr
 	groupedPrintJobs := make(map[PrintJobStatusGroup]int)
 
 	for _, printJob := range printJobs {
-		printerName := strings.Split(printJob.Name, ",")[0]
+		printerName, _, _ := strings.Cut(printJob.Name, ",")
 
 		if c.config.PrinterExclude.MatchString(printerName) ||
 			!c.config.PrinterInclude.MatchString(printerName) {

internal/headers/dhcpsapi/dhcpsapi.go

@@ -69,7 +69,7 @@ func GetDHCPV4ScopeStatistics() ([]DHCPV4Scope, error) {
 	var errs []error
 
 	for _, subnet := range subnets {
-		if err := (func() error {
+		if err := func() error {
 			var subnetInfo *DHCP_SUBNET_INFO
 
 			err := dhcpGetSubnetInfo(subnet.SubnetAddress, &subnetInfo)
@@ -129,7 +129,7 @@ func GetDHCPV4ScopeStatistics() ([]DHCPV4Scope, error) {
 			scopes = append(scopes, scope)
 
 			return nil
-		})(); err != nil {
+		}(); err != nil {
 			errs = append(errs, err)
 		}
 	}

internal/headers/psapi/psapi.go

@@ -52,7 +52,7 @@ var (
 func GetPerformanceInfo() (PerformanceInformation, error) {
 	var lppi PerformanceInformation
 
-	size := (uint32)(unsafe.Sizeof(lppi))
+	size := uint32(unsafe.Sizeof(lppi))
 	lppi.cb = size
 	r1, _, err := procGetPerformanceInfo.Call(uintptr(unsafe.Pointer(&lppi)), uintptr(size))
 

internal/headers/sysinfoapi/sysinfoapi.go

@@ -128,7 +128,7 @@ var (
 func GlobalMemoryStatusEx() (MemoryStatus, error) {
 	var mse memoryStatusEx
 
-	mse.dwLength = (uint32)(unsafe.Sizeof(mse))
+	mse.dwLength = uint32(unsafe.Sizeof(mse))
 	r1, _, err := procGlobalMemoryStatusEx.Call(uintptr(unsafe.Pointer(&mse)))
 
 	if ret := *(*bool)(unsafe.Pointer(&r1)); !ret {

internal/pdh/error.go

@@ -35,8 +35,7 @@ func (m *Error) Is(err error) bool {
 		return false
 	}
 
-	var e *Error
+	if e, ok := errors.AsType[*Error](err); ok {
-	if errors.As(err, &e) {
 		return m.ErrorCode == e.ErrorCode
 	}
 

internal/pdh/registry/perflib.go

@@ -254,8 +254,7 @@ func queryRawData(query string) ([]byte, error) {
 
 			continue
 		case err != nil:
-			var errNo windows.Errno
+			if errNo, ok := errors.AsType[windows.Errno](err); ok {
-			if errors.As(err, &errNo) {
 				return nil, fmt.Errorf("ReqQueryValueEx failed: %w errno %d", err, uint(errNo))
 			}