sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-10-25 13:09:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

collector: name instance labels after the entity they identify (#2744)

Browse Source 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This commit is contained in:
Jan-Otto Kröpke
2026-10-16 11:07:04 +02:00
committed by GitHub
parent 3fb18521f6
commit 667200f757
67 changed files with 1960 additions and 751 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AGENTS.md
+8
View File
@@ -115,6 +115,14 @@ exercised a live Windows role.
`_milliseconds`, `_microseconds`, `_kb` or an `_in_<unit>` infix. Convert
Windows values explicitly (MHz, percent, KiB, ms). Counters end in `_total`;
gauges never do. List renamed metrics in `UPGRADE.md`.
- Name the label that identifies a PDH or WMI instance after the entity it
identifies: `service`, `process`, `queue`, `disk`, `volume`, `nic`, `core`,
`vm`, `site`, `app`, `database`, `node`, `resource`, `resource_group`,
`cluster`, `network`, `pool`, `virtual_disk`, `connection`, `folder` and so
on. Never use the generic `name`, and never `instance`: it collides with the
target label that Prometheus adds. Reuse the key that other collectors use for
the same concept. Descriptive attributes of an info metric (for example the
processor model in `windows_cpu_info{name}`) are not instance keys.
- Determine metric types per counter, using `pdh.Collector.MetricType` where
appropriate. Raw PDH values can be cumulative numerators, ticks or counts,
even when the Windows counter name says average, percentage or seconds.