From 608b83cfd8cf3b04021788bf5f5ccae8b6147135 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan-Otto=20Kr=C3=B6pke?= Date: Tue, 21 Jan 2025 08:59:08 +0100 Subject: [PATCH] config: deprecate remote http configuration (#1849) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jan-Otto Kröpke --- installer/main.wxs | 5 +++-- internal/config/config.go | 8 ++++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/installer/main.wxs b/installer/main.wxs index 853c0627..523f8711 100644 --- a/installer/main.wxs +++ b/installer/main.wxs @@ -90,9 +90,10 @@ - + + - + diff --git a/internal/config/config.go b/internal/config/config.go index 5a2b0d27..aec44748 100644 --- a/internal/config/config.go +++ b/internal/config/config.go @@ -42,10 +42,14 @@ type Resolver struct { func NewResolver(ctx context.Context, file string, logger *slog.Logger, insecureSkipVerify bool) (*Resolver, error) { flags := map[string]string{} - var fileBytes []byte + var ( + err error + fileBytes []byte + ) - var err error if strings.HasPrefix(file, "http://") || strings.HasPrefix(file, "https://") { + logger.WarnContext(ctx, "Loading configuration file from URL is deprecated and will be removed in 0.31.0. Use a local file instead.") + fileBytes, err = readFromURL(ctx, file, logger, insecureSkipVerify) if err != nil { return nil, err