sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-02-08 05:56:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

update: remove deprecated flags (#2113)

Browse Source
This commit is contained in:
Jan-Otto Kröpke
2025-07-05 15:32:59 +02:00
committed by GitHub
parent bf722630d6
commit 4fd26fa0fa
1 changed files with 0 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
internal/collector/update/update.go
View File

@@ -87,21 +87,6 @@ func NewWithFlags(app *kingpin.Application) *Collector {
config: ConfigDefaults, config: ConfigDefaults,
} }
var (
online bool
scrapeInterval time.Duration
)
app.Flag(
"collector.updates.online",
"Deprecated: Please use collector.update.online instead",
).Default(strconv.FormatBool(ConfigDefaults.Online)).BoolVar(&online)
app.Flag(
"collector.updates.scrape-interval",
"Deprecated: Please use collector.update.scrape-interval instead",
).Default(ConfigDefaults.ScrapeInterval.String()).DurationVar(&scrapeInterval)
app.Flag( app.Flag(
"collector.update.online", "collector.update.online",
"Whether to search for updates online.", "Whether to search for updates online.",
@@ -112,33 +97,6 @@ func NewWithFlags(app *kingpin.Application) *Collector {
"Define the interval of scraping Windows Update information.", "Define the interval of scraping Windows Update information.",
).Default(ConfigDefaults.ScrapeInterval.String()).DurationVar(&c.config.ScrapeInterval) ).Default(ConfigDefaults.ScrapeInterval.String()).DurationVar(&c.config.ScrapeInterval)
app.Action(func(*kingpin.ParseContext) error {
// Use deprecated flags only if new ones weren't explicitly set
if online {
// If the new flag is set, ignore the old one
if !c.config.Online {
c.config.Online = online
}
slog.Warn("Warning: --collector.updates.online is deprecated, use --collector.update.online instead.",
slog.String("collector", Name),
)
}
if scrapeInterval != ConfigDefaults.ScrapeInterval {
// If the new flag is set, ignore the old one
if c.config.ScrapeInterval != scrapeInterval {
c.config.ScrapeInterval = scrapeInterval
}
slog.Warn("Warning: --collector.updates.scrape-interval is deprecated, use --collector.update.scrape-interval instead.",
slog.String("collector", Name),
)
}
return nil
})
return c return c
} }