From 4c9c78c599504415ccad536549aacf6c952c8461 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan-Otto=20Kr=C3=B6pke?= Date: Sat, 22 Feb 2025 09:29:02 +0100 Subject: [PATCH] time: fix panic if counters aren't present (#1898) --- internal/collector/time/time.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/internal/collector/time/time.go b/internal/collector/time/time.go index 40b055c8..b60763d0 100644 --- a/internal/collector/time/time.go +++ b/internal/collector/time/time.go @@ -125,13 +125,6 @@ func (c *Collector) Build(_ *slog.Logger, _ *mi.Session) error { } } - var err error - - c.perfDataCollector, err = pdh.NewCollector[perfDataCounterValues](pdh.CounterTypeRaw, "Windows Time Service", nil) - if err != nil { - return fmt.Errorf("failed to create Windows Time Service collector: %w", err) - } - c.currentTime = prometheus.NewDesc( prometheus.BuildFQName(types.Namespace, Name, "current_timestamp_seconds"), "OperatingSystem.LocalDateTime", @@ -181,6 +174,13 @@ func (c *Collector) Build(_ *slog.Logger, _ *mi.Session) error { nil, ) + var err error + + c.perfDataCollector, err = pdh.NewCollector[perfDataCounterValues](pdh.CounterTypeRaw, "Windows Time Service", nil) + if err != nil { + return fmt.Errorf("failed to create Windows Time Service collector: %w", err) + } + return nil }