From 492f3af31712cb95cf35dcee05466dfe4445ec19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jan-Otto=20Kr=C3=B6pke?= Date: Mon, 30 Jun 2025 19:55:45 +0200 Subject: [PATCH] diskdrive: fix not exposing state "Pred Fail" (#2101) --- internal/collector/diskdrive/diskdrive.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/internal/collector/diskdrive/diskdrive.go b/internal/collector/diskdrive/diskdrive.go index a1d77960..2ecca7bc 100644 --- a/internal/collector/diskdrive/diskdrive.go +++ b/internal/collector/diskdrive/diskdrive.go @@ -38,7 +38,9 @@ var ConfigDefaults = Config{} // A Collector is a Prometheus Collector for a few WMI metrics in Win32_DiskDrive. type Collector struct { - config Config + config Config + logger *slog.Logger + miSession *mi.Session miQuery mi.Query @@ -73,7 +75,9 @@ func (c *Collector) Close() error { return nil } -func (c *Collector) Build(_ *slog.Logger, miSession *mi.Session) error { +func (c *Collector) Build(logger *slog.Logger, miSession *mi.Session) error { + c.logger = logger.With(slog.String("collector", Name)) + c.diskInfo = prometheus.NewDesc( prometheus.BuildFQName(types.Namespace, Name, "info"), "General drive information", @@ -148,7 +152,7 @@ var ( "Error", "Degraded", "Unknown", - "Pred fail", + "Pred Fail", "Starting", "Stopping", "Service",