From 7f0973822c4a1852f409c271d13a1e8150d498d0 Mon Sep 17 00:00:00 2001 From: Calle Pettersson Date: Sat, 27 Aug 2016 11:29:57 +0200 Subject: [PATCH] Perf: Make exclusion of _Total label hardcoded --- collectors/perf.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/collectors/perf.go b/collectors/perf.go index 34b90fca..ed9062a3 100644 --- a/collectors/perf.go +++ b/collectors/perf.go @@ -15,7 +15,7 @@ import ( var ( volumeWhitelist = flag.String("collector.perf.volume-whitelist", ".+", "Regexp of volumes to whitelist. Volume name must both match whitelist and not match blacklist to be included.") - volumeBlacklist = flag.String("collector.perf.volume-blacklist", "_Total", "Regexp of volumes to blacklist. Volume name must both match whitelist and not match blacklist to be included.") + volumeBlacklist = flag.String("collector.perf.volume-blacklist", "", "Regexp of volumes to blacklist. Volume name must both match whitelist and not match blacklist to be included.") ) // A PerfCollector is a Prometheus collector for WMI Win32_PerfRawData_PerfDisk_LogicalDisk metrics @@ -401,7 +401,9 @@ func (c *PerfCollector) collect(ch chan<- prometheus.Metric) (*prometheus.Desc, } for _, volume := range dst { - if c.volumeBlacklistPattern.MatchString(volume.Name) || !c.volumeWhitelistPattern.MatchString(volume.Name) { + if volume.Name == "_Total" || + c.volumeBlacklistPattern.MatchString(volume.Name) || + !c.volumeWhitelistPattern.MatchString(volume.Name) { continue }