From 3bf94cdaf6130c760c6d68fe3fece52e5fd8ae3f Mon Sep 17 00:00:00 2001 From: Alexey Shumkin Date: Fri, 9 Oct 2020 13:45:49 +0300 Subject: [PATCH] Fix metrics description `windows_mssql_locks_lock_timeouts` and `windows_mssql_locks_lock_timeouts_excluding_NOWAIT` metrics have exchanged descriptions. According to https://docs.microsoft.com/en-us/sql/relational-databases/performance-monitor/sql-server-locks-object --- Lock Timeouts | Number of lock requests per second that (timeout > 0)/sec | timed out, but excluding requests for NOWAIT locks. --- Lock Timeouts/sec | Number of lock requests per second that timed | out, including requests for NOWAIT locks. --- Metrics gathered are correct but descriptions are exchanged. Signed-off-by: Alexey Shumkin --- docs/collector.mssql.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/collector.mssql.md b/docs/collector.mssql.md index bbc559af..bd44f0ac 100644 --- a/docs/collector.mssql.md +++ b/docs/collector.mssql.md @@ -194,8 +194,8 @@ Name | Description | Type | Labels `windows_mssql_genstats_user_connections` | Counts the number of users currently connected to SQL Server | counter | `instance` `windows_mssql_locks_average_wait_seconds` | Average amount of wait time (in milliseconds) for each lock request that resulted in a wait | counter | `instance`, `resource` `windows_mssql_locks_lock_requests` | Number of new locks and lock conversions per second requested from the lock manager | counter | `instance`, `resource` -`windows_mssql_locks_lock_timeouts` | Number of lock requests per second that timed out, but excluding requests for NOWAIT locks | counter | `instance`, `resource` -`windows_mssql_locks_lock_timeouts_excluding_NOWAIT` | Number of lock requests per second that timed out, including requests for NOWAIT locks | counter | `instance`, `resource` +`windows_mssql_locks_lock_timeouts` | Number of lock requests per second that timed out, including requests for NOWAIT locks | counter | `instance`, `resource` +`windows_mssql_locks_lock_timeouts_excluding_NOWAIT` | Number of lock requests per second that timed out, but excluding requests for NOWAIT locks | counter | `instance`, `resource` `windows_mssql_locks_lock_waits` | Total wait time (in milliseconds) for locks in the last second | counter | `instance`, `resource` `windows_mssql_locks_lock_wait_seconds` | Number of lock requests per second that required the caller to wait | counter | `instance`, `resource` `windows_mssql_locks_deadlocks` | Number of lock requests per second that resulted in a deadlock | counter | `instance`, `resource`