sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-10-17 18:19:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

pdh: fall back to localized names of v2 counter sets (#2709)

Browse Source 
Signed-off-by: Claude <noreply@anthropic.com>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Jan-Otto Kröpke
2026-10-15 09:49:25 +00:00
committed by GitHub
co-authored by Claude
parent 6b82e5a05f
commit 39277da8e5
4 changed files with 443 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
AGENTS.md
+5
View File
@@ -103,6 +103,11 @@ exercised a live Windows role.
instance occurrences within a sample; their suffixes are not stable identities.
Do not remove every name ending in `_Total`: legitimate process and database
names can use that suffix. Use the shared aggregate-instance policy.
- PDH collectors add counters by English path. On a Windows installation
without en-US resources, the 009 name table holds localized names for v2
(manifest-based) counter sets such as `SMB Server Shares` or `HTTP Service`;
`internal/pdh/localized.go` then maps the English names through the v2
registration API. Classic (v1) sets such as `Processor` are not affected.
- Keep `Build`, `Collect` and `Close` serialized for each collector instance.
Filtered `WithCollectors` views share execution state and do not own shutdown;
the original `Collection` owns collectors and MI resources. A timed-out call