sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-03-10 20:46:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

service: re-use buffer for return all services (#1853)

Browse Source 
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
This commit is contained in:
Jan-Otto Kröpke
2025-01-23 16:43:17 +01:00
committed by GitHub
parent 6b7201856c
commit 25e04fc947
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
internal/collector/service/service.go
View File

@@ -64,7 +64,8 @@ type Collector struct {
// ref: https://victoriametrics.com/blog/go-sync-pool/ // ref: https://victoriametrics.com/blog/go-sync-pool/
serviceConfigPoolBytes sync.Pool serviceConfigPoolBytes sync.Pool
serviceManagerHandle *mgr.Mgr serviceManagerHandle *mgr.Mgr
queryAllServicesBuffer []byte
} }
func New(config *Config) *Collector { func New(config *Config) *Collector {
@@ -140,6 +141,8 @@ func (c *Collector) Build(logger *slog.Logger, _ *mi.Session) error {
}, },
} }
c.queryAllServicesBuffer = make([]byte, 1024*100)
c.info = prometheus.NewDesc( c.info = prometheus.NewDesc(
prometheus.BuildFQName(types.Namespace, Name, "info"), prometheus.BuildFQName(types.Namespace, Name, "info"),
"A metric with a constant '1' value labeled with service information", "A metric with a constant '1' value labeled with service information",
@@ -209,7 +212,7 @@ func (c *Collector) Close() error {
func (c *Collector) Collect(ch chan<- prometheus.Metric) error { func (c *Collector) Collect(ch chan<- prometheus.Metric) error {
services, err := c.queryAllServices() services, err := c.queryAllServices()
if err != nil { if err != nil {
return fmt.Errorf("failed to query services: %w", err) return fmt.Errorf("failed to query all services: %w", err)
} }
servicesCh := make(chan windows.ENUM_SERVICE_STATUS_PROCESS, len(services)) servicesCh := make(chan windows.ENUM_SERVICE_STATUS_PROCESS, len(services))
@@ -368,16 +371,16 @@ func (c *Collector) queryAllServices() ([]windows.ENUM_SERVICE_STATUS_PROCESS, e
err error err error
) )
buf := make([]byte, 1024*100)
for { for {
currentBufferSize := uint32(cap(c.queryAllServicesBuffer))
err = windows.EnumServicesStatusEx( err = windows.EnumServicesStatusEx(
c.serviceManagerHandle.Handle, c.serviceManagerHandle.Handle,
windows.SC_STATUS_PROCESS_INFO, windows.SC_STATUS_PROCESS_INFO,
windows.SERVICE_WIN32, windows.SERVICE_WIN32,
windows.SERVICE_STATE_ALL, windows.SERVICE_STATE_ALL,
&buf[0], &c.queryAllServicesBuffer[0],
uint32(len(buf)), currentBufferSize,
&bytesNeeded, &bytesNeeded,
&servicesReturned, &servicesReturned,
nil, nil,
@@ -392,18 +395,18 @@ func (c *Collector) queryAllServices() ([]windows.ENUM_SERVICE_STATUS_PROCESS, e
return nil, err return nil, err
} }
if bytesNeeded <= uint32(len(buf)) { if bytesNeeded <= currentBufferSize {
return nil, err return nil, fmt.Errorf("windows.EnumServicesStatusEx reports buffer too small (%d), but buffer is large enough (%d)", currentBufferSize, bytesNeeded)
} }
buf = make([]byte, bytesNeeded) c.queryAllServicesBuffer = make([]byte, bytesNeeded)
} }
if servicesReturned == 0 { if servicesReturned == 0 {
return []windows.ENUM_SERVICE_STATUS_PROCESS{}, nil return []windows.ENUM_SERVICE_STATUS_PROCESS{}, nil
} }
services := unsafe.Slice((*windows.ENUM_SERVICE_STATUS_PROCESS)(unsafe.Pointer(&buf[0])), int(servicesReturned)) services := unsafe.Slice((*windows.ENUM_SERVICE_STATUS_PROCESS)(unsafe.Pointer(&c.queryAllServicesBuffer[0])), int(servicesReturned))
return services, nil return services, nil
} }