sendnrw/windows_exporter
2
0
Fork 0
mirror of https://github.com/prometheus-community/windows_exporter.git synced 2026-03-03 17:16:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #632 from prometheus-community/fix-hyperv-panic

Browse Source 
Fix panic in HyperV collector on input format mismatch
This commit is contained in:
Calle Pettersson
2020-10-26 09:01:37 +01:00
committed by GitHub
parent 7eab1fc411 49c082d594
commit 24fe6813b2
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
collector/hyperv.go
View File

@@ -1001,8 +1001,17 @@ func (c *HyperVCollector) collectVmCpuUsage(ch chan<- prometheus.Metric) (*prome
} }
// The name format is <VM Name>:Hv VP <vcore id> // The name format is <VM Name>:Hv VP <vcore id>
parts := strings.Split(obj.Name, ":") parts := strings.Split(obj.Name, ":")
if len(parts) != 2 {
log.Warnf("Unexpected format of Name in collectVmCpuUsage: %q, expected %q. Skipping.", obj.Name, "<VM Name>:Hv VP <vcore id>")
continue
}
coreParts := strings.Split(parts[1], " ")
if len(coreParts) != 3 {
log.Warnf("Unexpected format of core identifier in collectVmCpuUsage: %q, expected %q. Skipping.", parts[1], "Hv VP <vcore id>")
continue
}
vmName := parts[0] vmName := parts[0]
coreId := strings.Split(parts[1], " ")[2] coreId := coreParts[2]
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
c.VMGuestRunTime, c.VMGuestRunTime,